From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#71490: [PATCH] ; Fix customisation buffer for dired group Date: Tue, 11 Jun 2024 11:05:12 +0530 Message-ID: <87h6e059f3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17318"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 71490@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 11 22:42:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sH8KT-0004GG-Fa for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jun 2024 22:42:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sH8Jo-0004Y2-RT; Tue, 11 Jun 2024 16:42:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH8Jj-0004Vh-1V for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 16:42:07 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sH8Jh-00082F-BA for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 16:42:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sH8Jf-0006M1-L0 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 16:42:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2024 20:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171813848724167 (code B ref -1); Tue, 11 Jun 2024 20:42:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Jun 2024 20:41:27 +0000 Original-Received: from localhost ([127.0.0.1]:36745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8J4-0006Hd-TH for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:41:27 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:47004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8BO-0005td-9Y for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:33:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGuAD-0004z7-7t for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 01:35:21 -0400 Original-Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGuAA-00047n-LY for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 01:35:20 -0400 Original-Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-70417a6c328so2929487b3a.1 for ; Mon, 10 Jun 2024 22:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718084116; x=1718688916; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=wpf70kR5fsKYrIaiQSznV/ZC+PZoIJw+NKflqmGm8Lw=; b=R1rVUFdOHCKTmNh8bigOBDm+HF34ukP1BGhn/nbtTNKze/tM8TPw/UkzRUvvZUhTYS PwPRtNTE38Icf/5T/W6Uw/PiJ6nqD8bRuDTORpxZxD0289HALmabmBbj/7o8kwqHiRfk RfS4XpA2S6kzXudeRCBax09wS1RY5hs+09aU9nQkJVSLvED+likopz2cd4GyOkE8Mnri N9YR1+PogGdMtoziw/dQ1UJe85QCjsA33VdiJhyLCjsEBFdC7vHZCftLxwWGn18eitF7 GIIMPa33u2dT7GOvYy/Z7ul0jrkJxzgHcao+7dBlOhP5134voUTqdjjeI4JdalgG9MwR PzWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718084116; x=1718688916; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wpf70kR5fsKYrIaiQSznV/ZC+PZoIJw+NKflqmGm8Lw=; b=jjvfzps7oga4ldb0OxCxj4wGLj61eoh2I3zdeD/BinMk2+6ptdAgR7sDcFYyGHp9GJ mYByK6ta+2H2NASPd+kNQf9fLvp7rg5a8T9BvfcqdICGJYYtgUDgnL9w01nuBjpEIMlU tQXuyDRWnREW9PdGH/AoNSqoc6YFgxyMg0LgB1X93kIAR7SGHODPma9nVft1Kx9ZHxXO 9snAnAkqsyhq3mZR8h6KYc+VgsstFMhEPW20Z7tf+09zmflRbYeXEypWhMU4kCeIHCXj HSXlDs5F2QvfREu7ELdRW2wnCpMkb15TW1VNDt/yJvZykGxr+0kyAgRBQD/64nAQn9+X whlQ== X-Gm-Message-State: AOJu0YytmxTL8V7uC9OuqqHRrLyOtZgB+kZwNFEYw6IqzfdafUeBwQvK Wg1qDqS+juib2VCofMyA5D+Z1+hMelo/lMmpFEww/jMbfAcRbP8lYanilgBY X-Google-Smtp-Source: AGHT+IEdwScZQYVn9ZRfRWICAABnTgfM8vpgZBSjHJfbiA/OWaQhVe97GRc1iUFKwbS2wsl91DX2tg== X-Received: by 2002:a05:6a20:2443:b0:1b6:a1c1:b8ca with SMTP id adf61e73a8af0-1b6a1c1ba19mr5380298637.47.1718084115397; Mon, 10 Jun 2024 22:35:15 -0700 (PDT) Original-Received: from localhost ([103.232.241.147]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f7029c5d63sm40714405ad.299.2024.06.10.22.35.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 22:35:14 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=visuweshm@gmail.com; helo=mail-pf1-x443.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287124 Archived-At: --=-=-= Content-Type: text/plain Tags: patch To reproduce, 1. emacs -Q 2. M-x customize-group RET dired RET 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep In GNU Emacs 30.0.50 (build 8, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw scroll bars) of 2024-05-07 built on astatine Repository revision: 4b31074f5f49898ba0499a2b617cad425750eafa Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101011 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json --without-xaw3d --without-gconf --without-libsystemd --with-cairo --with-xft' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-customisation-buffer-for-dired-group.patch >From 628afa281e1c050a9fe49a4c362b1572c439c4d2 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Tue, 11 Jun 2024 10:51:39 +0530 Subject: [PATCH] ; Fix customisation buffer for dired group * lisp/dired-aux.el (dired-create-destination-dirs-on-trailing-dirsep): Actually concat the string. --- lisp/dired-aux.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index a2ce3083cfe..a0fa1ce6fe5 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -2218,14 +2218,14 @@ dired-create-destination-dirs-on-trailing-dirsep trailing /) is given or this option or `dired-create-destination-dirs' is nil, `old_name' will be renamed to `new_name'." - :type '(choice + :type `(choice (const :tag - (concat "Do not treat destination dirs with a " - "trailing directory separator specially") + ,(concat "Do not treat destination dirs with a " + "trailing directory separator specially") nil) (const :tag - (concat "Treat destination dirs with trailing " - "directory separator specially") + ,(concat "Treat destination dirs with trailing " + "directory separator specially") t)) :group 'dired :version "29.1") -- 2.43.0 --=-=-=--