From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Luis Henriques Newsgroups: gmane.emacs.bugs Subject: bug#72059: [PATCH] Ensure that git diffs without signature (--) are properly identified Date: Thu, 11 Jul 2024 13:20:32 +0100 Message-ID: <87h6cwm86n.fsf@orpheu.olymp> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27646"; mail-complaints-to="usenet@ciao.gmane.io" To: 72059@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 11 15:10:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRtZ9-0006vG-NB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jul 2024 15:10:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRtYl-0001mb-7W; Thu, 11 Jul 2024 09:10:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRtYi-0001dh-E2 for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 09:10:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRtYi-0001rO-26 for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 09:10:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRtYh-0003ge-Lu for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 09:10:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Luis Henriques Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2024 13:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72059 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172070336614080 (code B ref -1); Thu, 11 Jul 2024 13:10:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Jul 2024 13:09:26 +0000 Original-Received: from localhost ([127.0.0.1]:51252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRtY5-0003ex-MD for submit@debbugs.gnu.org; Thu, 11 Jul 2024 09:09:26 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRsn1-0002M9-O7 for submit@debbugs.gnu.org; Thu, 11 Jul 2024 08:20:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRsmy-0001x3-CM for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 08:20:46 -0400 Original-Received: from mout-p-201.mailbox.org ([80.241.56.171]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1sRsmw-0007wg-AA for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 08:20:44 -0400 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4WKYj01XQKz9svH for ; Thu, 11 Jul 2024 14:20:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camandro.org; s=MBO0001; t=1720700436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=BzuDbQOz48bc0zETWs9df8COemfxwQJlYZ80mk9GwxI=; b=qMufHaokCQTi6JCsBxUNk8Gv+iHr82tqA/ZdNDoj6L3AVLGShNWvpPCTkIrqC9ntNXx2RU YAobJSn5GrQDxWABciHkb3D/kVJ/QGh9v7HsT/p9ppGSuBP+Y2mKN+E+WHaNTCj7QACI3c BVJqB34quKEjhg++zzn3kqrQX8QdA4usQN7vRfXdx7mseuGnTk4/ONLolA85/Pgk5GYsPm eGgcDxc4g4ekWDtNgPBBpP+gVcATpDCEbg4HDXo0zdxixEyYLnjBCGDrpKeitDZzfR6Xed 7n+e9XlK2VUTgdX195sW3gInb/0aasuy2BWX9GeCs89qjNcL7oetoi5QRHuk/g== X-Rspamd-Queue-Id: 4WKYj01XQKz9svH Received-SPF: pass client-ip=80.241.56.171; envelope-from=henrix@camandro.org; helo=mout-p-201.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 11 Jul 2024 09:09:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288733 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! [Resending as I don't see message in the list after a few hours.] I'd like to have git-format-patch diffs to be properly identified when I'm using Gnus to read mailing-lists. It mostly works fine, *if* the (inlined) patches include a signature at the end ('--'). If the signature is missing then the patch isn't identified as such. Since all the other diff formats in mm-uu-type-alist don't have the 'end-point' I thought it would be fine to also remove it from the 'git-format-patch'. The issue I'm trying to fix can be easily seen in Gnus by comparing two emails with the following message-ids from the emacs-devel@gnu.org mailing-list: 87v81dmhxi.fsf@orpheu.olymp 20240702155100.2150717-1-brennan@umanwizard.com (These emails can be accessed by entering the Gnus group, hitting 'j' (gnus-summary-goto-article) and yanking the above message-ids.) Cheers, --=20 Lu=C3=ADs --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Ensure-that-git-diffs-without-signature-are-properly.patch >From fb9a1413655837607b2ed91d11d5cb2e3ba99415 Mon Sep 17 00:00:00 2001 From: Luis Henriques Date: Thu, 11 Jul 2024 10:02:04 +0100 Subject: [PATCH] Ensure that git diffs without signature (--) are properly identified * lisp/gnus/mm-uu.el (mm-uu-type-alist): Remove 'end-point' from git-format-patch diffs so that diffs without signature can be identified. --- lisp/gnus/mm-uu.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/gnus/mm-uu.el b/lisp/gnus/mm-uu.el index 3c7e3cbdf1af..f5d553bd0892 100644 --- a/lisp/gnus/mm-uu.el +++ b/lisp/gnus/mm-uu.el @@ -173,7 +173,7 @@ mm-uu-type-alist ,#'mm-uu-diff-test) (git-format-patch "^diff --git " - "^-- " + nil ,#'mm-uu-diff-extract nil ,#'mm-uu-diff-test) --=-=-=--