From: Karl Fogel <kfogel@red-bean.com>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: Possible bug getting bounds of URL at point?
Date: Tue, 16 Jul 2024 15:10:35 -0500 [thread overview]
Message-ID: <87h6cp9jyc.fsf@red-bean.com> (raw)
In Org Mode buffers, `bounds-of-thing-at-point-provider-alist'
names a Org-Mode-specific URL provider:
((url . org--bounds-of-link-at-point))
That handler is defined in org.el:
(defun org--bounds-of-link-at-point ()
"`bounds-of-thing-at-point' provider function."
(let ((context (org-element-context)))
(when (eq (org-element-type context) 'link)
(cons (org-element-begin context)
(org-element-end context)))))
(This is in the tree as of today, commit f2141541b45.)
I think this is causing URL boundaries to be calculated
incorrectly.
REPRODUCTION:
Assume we have this line in an Org Mode buffer (note there are
three trailing spaces after the final "m" -- hopefully the MTAs
and MUAs will leave those spaces there):
https://example.com
Let's say the initial "h" is at position 22205, the position right
after the final "m" is 22224, and the final position on the line
(after the three spaces) is 22227.
With point anywhere inside the URL, if I run
(bounds-of-thing-at-point 'url), I currently get this result:
(22205 . 22227)
But I expected this result instead:
(22205 . 22224)
Is (22205 . 22227) correct, and I'm just misunderstanding how URL
boundaries are supposed to work in Org Mode?
I haven't yet debugged into `org-element-end' (nor into
`org-element-property', which is what `org-element-end' wraps).
First I want to check that my expectations are correct.
Is there a bug here?
Best regards,
-Karl
next reply other threads:[~2024-07-16 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 20:10 Karl Fogel [this message]
2024-07-16 20:21 ` Possible bug getting bounds of URL at point? Ihor Radchenko
2024-07-16 20:34 ` Karl Fogel
2024-07-17 14:37 ` Ihor Radchenko
2024-07-17 17:05 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6cp9jyc.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.