bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

[Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

Philip Kaludercic <philipk@posteo.net> writes:

[...]

>> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
>> index cd948bd7dd9..97b1e28a4ff 100644
>> --- a/lisp/dired-aux.el
>> +++ b/lisp/dired-aux.el
>> @@ -1472,7 +1472,7 @@ dired-do-open
>>      (when command
>>        (dolist (file files)
>>          (cond
>> -         ((memq system-type '(gnu/linux))
>> +         ((memq system-type '(gnu/linux berkeley-unix))
>
> Are these the only systems with xdg-open?

I don't really know.  I guess that FreeBSD and NetBSD also have ports of
xdg-open.  But I don't know for others "berkeley-unix".  Anyway, this is
less restrictive than just "gnu/linux".

> And is xdg-open reliably available on BSD systems, so that we don't
> generate an opaque error message if that is not the case?

I think it would work whether xdg-open is install or not because
`shell-command-guess-open' is defined by testing the presence of
xdg-open.  So if xdg-open is not installed, `command' in the code above
will be nil and nothing will happen.
-- 
Manuel Giraud