From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Date: Sat, 21 Sep 2024 09:28:40 +0200 Message-ID: <87h6a979ef.fsf@gnu.org> References: <87cyky43fb.fsf@ice9.digital> <86setu5f85.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25479"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.6; emacs 31.0.50 Cc: Morgan Willcock , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 21 09:29:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sruYg-0006Uk-9a for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Sep 2024 09:29:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sruXw-0002x8-61; Sat, 21 Sep 2024 03:28:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sruXu-0002wu-PR for emacs-devel@gnu.org; Sat, 21 Sep 2024 03:28:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sruXt-00041v-TT; Sat, 21 Sep 2024 03:28:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=GTYYPvrA7LW8PS0/Av+cizgpStFGXKifbhrBZLXbWiw=; b=qLerxWAX7gTd5BEqee/u wY3QCqPL2LPg4cjnymkyTHRDF6w0BZJiLT6gyVKAP1sPNYkQ4cccpSKkVpUminIowazWjCl+hY/Jj cSPoHx+cTaudVSdtcr5qvy2LNZjqDG+xV1U0lwbHKEUpKFh5Y064NnFgAgmFtkRqleymbuhfwZRDo /455WqzCXP1CQxu7xR22wIRnKsKtwuLPQB5dYxtJkTkl2PYVt9sAhAKuAfReuyyE+gKlUzhixly6x 0ZGlGDB3WS8Qf9nFLr9xuOU+LvUQKxyfHVLudIBCc2mpTsdFTnlcbfOingo0am/tj6z6mXEOOQqyg 7ajKBHM9kSaV9A==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudelgedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne cuggftrfgrthhtvghrnhepleduvdegfeduvdejkeefteelgeetgfevhefhueffueffgeeh gfeufefgvdffgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepvghmrggtshdquggvvhgvlhesghhnuhdrohhrghdprhgtphhtthhopehmohhrghgrnh esihgtvgelrdguihhgihhtrghlpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-Reply-To: <86setu5f85.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Sep 2024 21:53:30 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323882 Archived-At: Eli Zaretskii writes: >> When testing the Emacs 30 pre-release I found that all of the PDF >> files which I tried to view were not readable because the text >> appeared to be missing. >> >> Eventually I found the variable doc-view-mupdf-use-svg, and setting >> it to nil reverted the rendering to the old method where the text was >> visible. > > Why is that? If your system supports display of SVG images, why > wasn't the text readable? Tassilo, any ideas? I suspect it's some sort of background-equals-foreground issue. I think by default, the SVGs have transparent background. So when you use a dark theme (I tested with the built-in modus-vivendi theme which is very dark), you might get black foreground on black background. Visuwesh already cited the cure: in emacs 29 you might want to set doc-view-svg-foreground/background to white/black or vice versa (and then re-convert your PDF). In emacs 30, that has been replaced with the face doc-view-svg-face where you can customize foreground and background such that the contrast works for you and your theme. Hm, but doc-view-svg-face inherits from the default face and that is white-on-black with modus-vivendi, so actually it should all be good, i.e., the PDF display should match your theme. However, depending on PDF I tested, I sometimes get white-on-black display (good!) and sometimes darkish-on-black (bad!). It seems like it works as intended for "standard black-on-white PDFs" but doesn't really work when the PDF is "fancy", e.g., gray foreground or colorized borders or what not... Bye, Tassilo