From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Tue, 01 Oct 2024 09:40:34 +0800 Message-ID: <87h69wppm5.fsf@melete.silentflame.com> References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> <87y13dfgzz.fsf@melete.silentflame.com> <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> <87h69ydnvd.fsf@melete.silentflame.com> <878qv9scps.fsf@melete.silentflame.com> <12b28146-5cbc-48cd-b0e2-0c528d4b9b1c@yandex.ru> <87ikudqocz.fsf@melete.silentflame.com> <9be40a05-3260-40a8-9c35-c5daac413844@yandex.ru> <87wmisprfk.fsf@melete.silentflame.com> <16230560-cad5-4cc9-a272-a0f961247158@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5308"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73387@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 01 03:41:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svRtl-00019w-JW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Oct 2024 03:41:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svRtM-00062c-M8; Mon, 30 Sep 2024 21:41:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svRtK-00062L-G2 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:41:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svRtK-0000kA-79 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:41:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=w6BBlTKfjiJkzU2lyltCCtLfLQjlnBErv8XYgFACNVA=; b=W2mhp+LEoaMRjLG1IRoj5dp/3ADQdg94aXiGCzXHNtPKMLtrd7RinK5PB4J5L2ZmEM3wnpu7VXgVs7L2zo41XQrzmZT2wdkGWoQafLIPl7XLqNpNhIMKrm05GEz9oJ9cbAbfpNPRkUDwzHAwWNjJ3S2tcbm0hhNsK/OrZSsnQH4421bB9TGXjvPnRL8vX5l6okMVlDmHNlCFRnKNYvJ+lbMzCrlodLb8SULzIxCEvS5eATEODt5dYjWIE24Hbfn/VkBEwvhnUSzesv4WLuQUhrr7h5Is9pQI8JVlO+pwR5NeWMkjydrF+B8hGYoPOf/CCf7lCsmD3to6J1qH/A8Ihw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svRtq-0002Fw-K0 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2024 01:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.17277468818646 (code B ref 73387); Tue, 01 Oct 2024 01:42:02 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 1 Oct 2024 01:41:21 +0000 Original-Received: from localhost ([127.0.0.1]:48312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svRtA-0002FN-TB for submit@debbugs.gnu.org; Mon, 30 Sep 2024 21:41:21 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:55152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svRt8-0002FE-Il for 73387@debbugs.gnu.org; Mon, 30 Sep 2024 21:41:19 -0400 DKIM-Signature: a=rsa-sha256; b=MubJRhzU+2/L4zWa9h4M105faY1OfJZGDj0aw4EqH6HoMGrSoh/8gJos6YjbYyRc/Xmqlv0ZffqlTMbQPebOj909RAdGkpSUPEds6joIGX9r/z8UYOhWKu5uMqvFBfCIiFQEYytfsDhaBZYxlZXX2sGH2amBu3aqt9PqP/nzzHWvd1HYM7jFZKEv4JqtFXo0HzhYOWi7p5G34eX1fwQckI38DdANmvEQP5eZORX+7T84gk9xox3QKDeTW3ZM2F1wtAG5hQh9/sSTxCq1CseYWfN3gTgrPQZmdk2W+O2Lwb5LkQSCmJwqs7qpfHPhuIfaAGF0jiHKWKjrL9j+3sC89A==; s=purelymail2; d=spwhitton.name; v=1; bh=SnA4L8+asmtkZaozmO2Mg5TUfN9TPsNUBEdQR6NqgRk=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=vTy94n3AVx7S7NrXLFoh0OuG7SwNfFxEfusCDYfYUF9llGPVk0HawtlzWWyIhtjdCuWMNdgIzO4anLBlyZ4kiAFfGvaiG6j4T63oiIPJrnrIHMqNtjgnV9hD2zQKlO07G104QoEpqaNlmwlFUlPR35KD9LcbA/rn0AiHN1VvlUvrILWMIFIonZkyYcmTDShTkaL1eNknrQDW5eEvMmJR+6A6g4OUlW7ZxvUCYMSCg7lh0bJmZTKjyDtFKQTsKzlB64Y0zBBqkpYtH1FDn5pJQM3e6JH/bb6XVX5SvjyMQHv2ij5PTyQkm2POhFNIDdjjbNHHDrH+QiJktpfkXDzBMQ==; s=purelymail2; d=purelymail.com; v=1; bh=SnA4L8+asmtkZaozmO2Mg5TUfN9TPsNUBEdQR6NqgRk=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73387@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1500970189; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 01 Oct 2024 01:40:37 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 77DB17E25C6; Tue, 1 Oct 2024 02:40:34 +0100 (BST) In-Reply-To: <16230560-cad5-4cc9-a272-a0f961247158@yandex.ru> (Dmitry Gutov's message of "Tue, 1 Oct 2024 04:15:19 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292755 Archived-At: Hello, On Tue 01 Oct 2024 at 04:15am +03, Dmitry Gutov wrote: > On 01/10/2024 04:01, Sean Whitton wrote: >> I don't think that's quite right. >> >> If you use C-c C-n in a diff-mode buffer with current master, then >> C-x v v doesn't get far enough to call the user-error I added. >> "No next file" is not the error message that you should get. > > Ah, okay. > > Building the list and then not using it feels kind of wasteful, though. > > Should we move the check earlier? > > I.e. do this (and probably remove it from vc-next-action): Is it right that diff-vc-deduce-fileset will only ever be called in the context of using C-x v v to commit a patch? The name of the function suggests that it might be used for something else, if not now then in the future. -- Sean Whitton