From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#73812: 30.0.91; ERC 5.6.0.30.1: Customizing erc-modules loads ERC when starting Emacs Date: Tue, 15 Oct 2024 11:00:38 -0700 Message-ID: <87h69ddz5l.fsf__34404.0478974179$1729015326$gmane$org@neverwas.me> References: <87o73mgjk3.fsf@neverwas.me> <865xptsh6f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26394"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73812@debbugs.gnu.org, emacs-erc@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 15 20:02:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0lrs-0006jg-6b for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Oct 2024 20:02:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0lrd-0006ry-3i; Tue, 15 Oct 2024 14:01:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0lrc-0006rl-D4 for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 14:01:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0lrc-0000xt-40 for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 14:01:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=NexnMhgVjngwCBJG2gIDCP7yJBfT2Q1/Oi+MU7mNcas=; b=sXIlX6qx1YHQQe0hlI7MqHVbncOFlPnT4/9wWJgjiXvT30xwwUfTixksHr+EWCoe1HCDBdu7BifoGj2as5SOf07PdFlkao9tVjFbNf1PCn3TNUZcYIhleHY173fDlwVYk9zPXHxP4aKDqIiOYk/1Q44yiW38rp1Y8djHEaWZm2rfy7kA6DkZBmsm4BhmaFCzIDfjQgudLx6/rcsu8727hcW2L4PxQHK0pJuWiPjuJE4fk+j2y7LfbS0OSGLOWpToW15UqqmnfWJpgrR/8oGQdn/rZLfbmhIz3ZvMAOAUsmCu1Ml9IyUFV5E9fRmI8JvA5uUB5+1z7Mv5OSF8TGaGsA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0lru-0000Ws-Gi for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 14:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2024 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73812 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73812-submit@debbugs.gnu.org id=B73812.17290152681964 (code B ref 73812); Tue, 15 Oct 2024 18:02:02 +0000 Original-Received: (at 73812) by debbugs.gnu.org; 15 Oct 2024 18:01:08 +0000 Original-Received: from localhost ([127.0.0.1]:57372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0lr1-0000Vc-ER for submit@debbugs.gnu.org; Tue, 15 Oct 2024 14:01:07 -0400 Original-Received: from mail-108-mta126.mxroute.com ([136.175.108.126]:36907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0lqz-0000VT-7x for 73812@debbugs.gnu.org; Tue, 15 Oct 2024 14:01:06 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta126.mxroute.com (ZoneMTA) with ESMTPSA id 1929156d8f90003e01.001 for <73812@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 15 Oct 2024 18:00:40 +0000 X-Zone-Loop: d2bb27905f0f7027253207dc6e8814c7b2ac3ffb5156 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NexnMhgVjngwCBJG2gIDCP7yJBfT2Q1/Oi+MU7mNcas=; b=YDEglR7z8nN+V3o4UluKJokyct gk6e5ksJy9SzgM4ISVYRICQyzC8FWoDVzI0H0yim4rapzTRRjS0lbWQaMdQ29EdR/iT5HgLyGf7kM m8GQ7pRFx3ovizVwNuWXUTyBizYfaQhw0m1DcGbGqM/bDvTvVRucRHemJQN9dqUByEI6Z5J+qs7p8 CoLTLLwk+NidWfy/kvPEKmD5fvOLzKzIK7abK11ELA6DWKQJfYcj/NVa5quatufN7R0bs/J4Trug2 2nyJZHu7wKmWvRN5XzmOwEGVzwYWyeqadFkJ6DZuOPL1rh5LR3mM980xcskwKZB02uO17LmYWEn5c V4IU9cxw==; In-Reply-To: <865xptsh6f.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Oct 2024 15:07:36 +0300") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293634 Archived-At: Eli Zaretskii writes: >> Cc: emacs-erc@gnu.org, Eli Zaretskii >> From: "J.P." >> Date: Mon, 14 Oct 2024 19:57:00 -0700 >> >> >From emacs -Q >> >> 1. $ mkdir /tmp/fake-home >> 2. $ echo "(custom-set-variables '(erc-modules ()))" > /tmp/fake-home/.emacs >> 3. $ HOME=/tmp/fake-home ./src/emacs >> 4. M-: (featurep 'erc) RET >> >> Eli, can we add this patch to the release branch? It removes a single >> line containing an autoload cookie that's new in Emacs 30. (I'm running >> the check-expensive suite with the patch now.) Thanks. > > Are we sure this doesn't break any customization scenarios? The worst case is probably someone unaware of the implicit loading who recently added code referring to symbols defined in erc.el after an Emacs-managed `custom-set-variables' form in their `custom-file' (or a `:custom' section in a `use-package' declaration). These customizations would necessarily have to contain an entry for `erc-modules', but this is perhaps the most common ERC customization. However, the user would have to be running the pre-release or master. > Why was this line added in the first place? The line was initially added in a misguided attempt to allow new users unfamiliar with Emacs to run M-x customize-option RET erc-modules RET without first having to run M-: (require 'erc) RET. > And why is it urgent to remove it before Emacs 30 is released? ERC has a great many symbols, which people won't want to see in completion tables, etc. Longtime ERC users trying Emacs 30 for the first time may find ERC loading whenever they start Emacs, which may not be desirable in all Emacs sessions. And since, as mentioned, `erc-modules' is likely among the most commonly customized of ERC's options, this may also affect non-ERC users who perhaps only tried it once many years ago or even folks using a shared config containing such a customization. For these reasons, I suspect we'll start noticing ERC-related pollution in the automated evidence collection for bug reports filed with M-x report-emacs-bug RET once Emacs 30 goes mainstream.