From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Sun, 20 Oct 2024 08:58:52 +0800 Message-ID: <87h697vbcj.fsf@melete.silentflame.com> References: <87pm5yo4m7.fsf@gmail.com> <87legmnq4l.fsf@gmail.com> <87r090o8cl.fsf@melete.silentflame.com> <874j5vgypf.fsf@melete.silentflame.com> <787fb692-db24-4682-871b-5a52d31a1249@gutov.dev> <87ed4obs1b.fsf@melete.silentflame.com> <87jze6vwtx.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5715"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Morgan Smith , Robert Pluim , 64055@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 20 02:59:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2KIS-0001Jn-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Oct 2024 02:59:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2KIF-0005ML-0e; Sat, 19 Oct 2024 20:59:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2KIE-0005MC-4h for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 20:59:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2KID-0001sA-Sa for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 20:59:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=3x8U7Q8rNQ9biZg6nzi4xVcCx4Yc0tTWS/DQkCradyI=; b=joXO4g9IAAJh0q5N9UzHsTRYgepPRKov+IY8HPI9ZH4QCUMWaNhysabez5SkCIFIe/yR2ewlgHbMKbwlhTw7toYtqaXuj2SPsn+4npcV0gCU4/xNKPZtS8aeKGAtiPImx5hefJL9Mlb7wOhNr5jNFQV20xugihzrbVDfjlcFn8YnYdsBxCEpH39nMI2Dwv58xbfcS8CqcAVH13SfnUBHRCNeO2tPggrI6T1ppQvGuT8HzIYT3bSU1J4xYATvVazm4oHBjM09JBpCRo+XTXXpBuqRCphclfINqYDXnoPJd33x0l1W3ujZ6jTQ1Kx2T/0gEjV37vorjAP502AYYf1UPA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2KIc-0006Yo-8H for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 21:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 01:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.172938597625153 (code B ref 64055); Sun, 20 Oct 2024 01:00:01 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 20 Oct 2024 00:59:36 +0000 Original-Received: from localhost ([127.0.0.1]:45197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2KIB-0006Xd-RT for submit@debbugs.gnu.org; Sat, 19 Oct 2024 20:59:36 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:46366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2KIA-0006XQ-3l for 64055@debbugs.gnu.org; Sat, 19 Oct 2024 20:59:34 -0400 DKIM-Signature: a=rsa-sha256; b=eBGoP5F5DPGRwZzH7rfu95GHwrQYBzlXRmkmMYkVQCOdzdQrUNS8w7NQkl2c5QHDSZPDvmCpwewLifpUaGU0X5ou5P6lvV+XBO9jUWNl2Y7fOIsO9Ud8i45UGTIoMRGwXKfnboBsTtN7VWkV7eWYtur+s4vttx7Afn/a33vLTqmTUHAaKgYKY/NNSHaQlvyM8jR9+N01aK2107IrDyTqqK1Q6+k6KDzlw24BCr7uu9ipTzrqY0XrczSPh5fw2WkKri9viizqhEuL0W5fGUYSeiAErrj36w8s4TY8qqMsrqQt+sk6AS6buzENrKFLhEhqL3TxzBL1j1ptpPj6QcwcMw==; s=purelymail1; d=spwhitton.name; v=1; bh=xq7dJtiFcbyza3SRMhYCP+yxb3X9lJvNx+Zruyx6Xn0=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=nh8s2VCAYGybpX/N2BfuJ/9Dc2JwEj7R5yDzZXr5mdDY9ek/kBlXUP97bFx6np69w4Hmi/hQasGjlw4XeGDrS8F96Jkv9xkht+2CkKdWb+0XFZTAs1WjcWjVGe2w4JqX14CUINStnv2eJ5O4c0LPbiEOwm0FABgOkfCNibOLAAncr6/7fKRrmo/P/M8QdE6rWFdcilSzepcVm1IK8OgIL4NXtwVyPDUSaJD9Dde7StyjmaUS5ZT15e+/t53tfF5f1qdm6ZL0Tu1jtLDQFTOMdboiitTurjBiYvwufLVeu2evvI9CK33eIfuFXnr972ZFO7P3r4fuwnGSX9VKQ2RVwQ==; s=purelymail1; d=purelymail.com; v=1; bh=xq7dJtiFcbyza3SRMhYCP+yxb3X9lJvNx+Zruyx6Xn0=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 64055@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1529162964; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 20 Oct 2024 00:58:56 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 90A007E8333; Sun, 20 Oct 2024 08:58:52 +0800 (CST) In-Reply-To: (Dmitry Gutov's message of "Sun, 20 Oct 2024 01:16:25 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293919 Archived-At: Hello, On Sun 20 Oct 2024 at 01:16am +01, Dmitry Gutov wrote: >> I thought that it would be nice to include Author, in particular, as you >> might need to amend the value. That would require adding additional >> arguments to the modify-change-comment action, though, so I left it for >> later if someone wants to implement it. > > I think you're parsing out all the headers from the COMMENT argument in the > posted patch, so this paragraph seems to be moot. Yeah, I realised that because we are invoking git-commit(1), it's easy to support most of them. > Like you say in the patch though, it seems changing Author is not > supported. > > To do that, apparently we'd either need to rebase with a pause (with 'git > amend' in the middle), or use 'git rebase --exec' like in > https://stackoverflow.com/a/79068024/615245. The latter seems like it would > apply to all commits in the range, so it might require the same dance as > 'amend'. Yeah. We can consider it as a possible future enhancement. I'm also concerned about it making the command slower -- it's already not that fast. > (I can comment on the patch itself tomorrow.) Cool, thanks. -- Sean Whitton