Re: patch : ob-sql :session

[Ihor Radchenko <yantar92@posteo.net>]

Phil Estival <pe@7d.nz> writes:

> I will keep running ob-sql with :session in the next days.
> This work configuration should help to detect if there is an anomaly.
>
> Shall I submit a patch?

Sure!

> Since many lines are changed due to proper indentation, docstrings,
> untabification and a few lateral improvements, I was wondering if
> such a patch has to be gradual and minimize sudden changes.

If you can make a series of patches introducing individual changes, it
would be best. A single patch will also be ok.

> Also I'm trying to run the tests with
>
> : make BTEST_RE='ob-sql.*' test-dirty
>
> but they get skipped due to a missing dependency,
> and I don't know in which direction to look for from there.
> Below is what the command returns. Any idea ?

Check your local.mk
ob-sql tests are disabled by default. You need to modify BTEST_OB_LANGUAGES

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>