From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Sat, 23 Nov 2024 20:25:30 +0200 Organization: LINKOV.NET Message-ID: <87h67xren9.fsf@mail.linkov.net> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> <86serntf0h.fsf@gnu.org> <86h680rhxr.fsf@gnu.org> <87h680fotv.fsf@mail.linkov.net> <864j40pfbw.fsf@gnu.org> <87bjy8e5qc.fsf@mail.linkov.net> <86y11cnyws.fsf@gnu.org> <87iksfpwlr.fsf@mail.linkov.net> <86jzcvof10.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12291"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: dmitry@gutov.dev, 74361@debbugs.gnu.org, rudalics@gmx.at To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 23 19:32:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEuvd-00035H-4R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Nov 2024 19:32:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEuvL-0000hh-Sf; Sat, 23 Nov 2024 13:32:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEuvK-0000fa-M1 for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 13:32:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEuvK-0006R1-D1 for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 13:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=b9qEWCXLTYJHJYlB9bMrv/4ML4HbVciXPxWRDL9nkms=; b=bmPzY1l2bacgLU1Egf111N/hZGsAkPEOnx+UskcVmjVaHkxY+7JzPw+Q2yreEYxGRUtg+zXXOxfp3J3IlgIrJbJNeb9fjden8Nn0xIqR/7Vc1tLfOfV9Sh1QEJ0V+95v8tdvuNnC7QwrMgKhbvCj/k8A8kwMRqkmTBIsCw+kZVXIHSqmCQDj83Ln5BlouryhYSAw/Z2D3rWfXbA8tFF2jPcUHxabs8uwf4d8RIHAqVicgFZfMu2dJ6wdlgjZsbzeiM4Inpbb1cTtw9z7S7tgHKVyvP3+vHokUsESV+lVSGrz/wdheYiKuVf9hN5nDqXaRT0iQQop8t3Qyq1nbmTqlw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEuvK-0006LM-74 for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 13:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2024 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173238667124270 (code B ref 74361); Sat, 23 Nov 2024 18:32:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 23 Nov 2024 18:31:11 +0000 Original-Received: from localhost ([127.0.0.1]:59110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEuuV-0006JD-7Q for submit@debbugs.gnu.org; Sat, 23 Nov 2024 13:31:11 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:52469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEuuU-0006Hc-6t for 74361@debbugs.gnu.org; Sat, 23 Nov 2024 13:31:10 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 4C5421BF203; Sat, 23 Nov 2024 18:30:42 +0000 (UTC) In-Reply-To: <86jzcvof10.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Nov 2024 10:20:59 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295859 Archived-At: >> > (make-obsolete-variable >> > 'display-comint-buffer-action >> > "use a `(category . comint)' condition in `display-buffer-alist'." >> > "30.1") >> >> The categories are a replacement only for customization. >> But all display-buffer calls should still contain >> `(category . comint)' that currently presented >> in these variables. IOW, the variables currently >> are used in two ways: >> 1. as the default values for display-buffer calls >> 2. as user options >> >> But now customization is supposed to be only with >> the help of `(category . comint)' in `display-buffer-alist'. >> So these variable will be used only in display-buffer calls. >> >> > So if some user wants to take our advice and modernize his/her >> > customizations to use '(category . comint)' instead of >> > display-comint-buffer-action, the customization will stop working for >> > him/her when we remove those obsolete options in some future Emacs >> > version. Right? Or what am I missing? >> >> These are two possible solutions: >> 1. Demote these options to variables not intended for customization. >> 2. Move their current default values to display-buffer calls. > > I expected to see us do #2 at the same time we deprecated the user > options. I don't understand why we didn't do that. The deprecation > message clearly tells users not to use these variables, so it's > reasonable to expect them to be deleted. Moreover, their presence in > our sources is a potential cause for byte-compilation warnings. Immediate #2 will break customization for many users. We have to give enough time between two releases to allow the users to see a warning and adapt their config files to upcoming deletion of these options.