From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#74556: 30.0.92; Package upgrade can fail and results in deleted package Date: Tue, 10 Dec 2024 20:31:59 +0000 Message-ID: <87h67bxosg.fsf@posteo.net> References: <87plmgq55e.fsf@daniel-mendler.de> <87zflj62ai.fsf@posteo.net> <87v7w7617o.fsf@posteo.net> <86ttbfism4.fsf@gnu.org> <87v7vvz0ay.fsf@posteo.net> <87zfl3h93m.fsf@daniel-mendler.de> <87ldwnxppc.fsf@posteo.net> <87pllzp9q4.fsf@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19207"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 74556@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 10 21:33:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tL6v9-0004hz-1K for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Dec 2024 21:33:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tL6un-0004hP-5j; Tue, 10 Dec 2024 15:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tL6ul-0004h9-Qb for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 15:33:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tL6ul-0000vR-Bj for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 15:33:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=T8r2ajoRvusiT9I2Xix7XxC5DwUjljXbyx/8Jdrf53Y=; b=uQ8jgj9zgtUHJYRIK7EKp4rDRiC9aKjSH+09O3OHKxzRLmG5RneF+ySVSz72nlKZEOehbfyocP8aYL2gBYuOEEovdKwfNwUDacHe5rmMfz+vC32NhZM5j3Fz63Fq1sb0DUs32NoxlvWqTaQP07ykllFYISmTe+gaW3Li3BsM8LIeKxt3+iL7jCryqcofkVLQTsiwm0Ww4BZuufd6CkM/ixmvAQT/wt21wWDmjoii+ZYVzFKWHjFFKQjLRcQnSUZZeNhGW6sy+qEH74DdwHQaUC3e1LrXyH7LMbFTyG6y+xDzJLsosAUxyS4b121/ag/UDYMFE/9qo2voQbjfcAVgbQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tL6uk-00074Z-Bu for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 15:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2024 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74556 X-GNU-PR-Package: emacs Original-Received: via spool by 74556-submit@debbugs.gnu.org id=B74556.173386273126992 (code B ref 74556); Tue, 10 Dec 2024 20:33:02 +0000 Original-Received: (at 74556) by debbugs.gnu.org; 10 Dec 2024 20:32:11 +0000 Original-Received: from localhost ([127.0.0.1]:59762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL6tu-00071F-As for submit@debbugs.gnu.org; Tue, 10 Dec 2024 15:32:10 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:38721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL6tr-000707-Ii for 74556@debbugs.gnu.org; Tue, 10 Dec 2024 15:32:08 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 415CE240105 for <74556@debbugs.gnu.org>; Tue, 10 Dec 2024 21:32:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1733862720; bh=2gX2lbsypuTpB3ZInbzJuqp5ascZWIchYJcuuwCmM9E=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=e8/s2b1h+ZmyyKc28n5aLqeqvLt8sbvReZsZqGODkvisUFDLrel2mhsCe2W0cchIu ++lLFOeIJSAPppWRDFXjeZp7uE0IGTTsttaD3DbcOO0k5o9t38A7o9Wsr9iACWDLLT uLt2p4FXHtkfHZIPwbR6kSa2eCBa+ishbZWFOMi5iG0RmzhkP9rg4LvG5TUuzwIOBT 3ex6znJLWfS3VDjimjwg6uhkdxqp2dFRlbXjS22zvdPmmWCOL2mDlI2FC1TKREbCZ+ 1zX/vU16tWGVIS98Hm/D++xsOtFyywwJp4q984ERs6+gaGhCKF8xlM3Ms/vQW/fYuA aO8v8cKRkl3Ig== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y79Pq4Gp9z9rxK; Tue, 10 Dec 2024 21:31:59 +0100 (CET) In-Reply-To: <87pllzp9q4.fsf@daniel-mendler.de> (Daniel Mendler's message of "Tue, 10 Dec 2024 21:24:35 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296784 Archived-At: Daniel Mendler > Philip Kaludercic writes: > >> Daniel Mendler writes: >> >>> Philip Kaludercic writes: >>> >>>> Eli Zaretskii writes: >>>> >>>>>> Cc: 74556@debbugs.gnu.org >>>>>> From: Philip Kaludercic >>>>>> Date: Thu, 28 Nov 2024 11:34:51 +0000 >>>>>> >>>>>> Philip Kaludercic writes: >>>>>> >>>>>> [...] >>>>>> >>>>>> > It might make sense to try and "deactivate" a package before installing >>>>>> > the new package. Looking into some second-try fallback for >>>>>> > package-install to refresh the package index if a package was not found >>>>>> > would also be a good idea ^^ >>>>>> >>>>>> This might do it? >>>>> >>>>> Philip, please install this on the emacs-30 branch, unless you see any >>>>> problems with the change. We'd like to make another pretest soon. >>>> >>>> Done. But we should keep the report open as there might be better >>>> approaches to discuss in the future. >>> >>> Hello Philip, >>> >>> I just tried the modified `package-upgrade' function and it doesn't seem >>> to work. It seems to break the upgrade procedure in an even worse way, >>> at least in my setup. Now `package-install' is tried first with the >>> package symbol, which will be a no-op, since the package is already >>> installed. Afterwards the package is deleted and we always end up with >>> no package. Probably `package-install' should also be called with a >>> package descriptor of the new package version? >> >> Right, my sincere apologies for that oversight. That being said, I >> don't feel comfortable fixing this right now as I am short on time to >> fix and test something like this on the "emacs-30" branch. My vote >> would be to revert the commit and try to tackle the issue on the >> "master" branch. An alternative I can propose that would be closer to >> the original code might be > > Yes, I also vote to revert your commit on the emacs-30 release branch. > The issue isn't severe (and not a regression), so I'd say it is okay to > fix the issue on the master branch. Eli, what do you say? > I don't understand how the code you proposed works. It seems that after > the deletion, if the installation fails, the package will stay deleted? > Anyway, no hurry from my side to get this fixed. Forget it, I didn't think it through. > Thanks. > > Daniel