all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Yuan Fu <casouri@gmail.com>
Cc: 75198@debbugs.gnu.org
Subject: bug#75198: 31.0.50; [treesitter] peculiar error
Date: Sun, 05 Jan 2025 09:43:41 +0200	[thread overview]
Message-ID: <87h66d9042.fsf@mail.linkov.net> (raw)
In-Reply-To: <E151C5AD-B910-43EC-B580-1F352111D667@gmail.com> (Yuan Fu's message of "Sat, 4 Jan 2025 11:22:54 -0800")

>>> It’s better for these functions to check whether the definition of the
>>> thing they’re going to use exists or not, before calling
>>> treesit-node-match-p; alternatively, if they know they don’t care,
>>> they can pass t to IGNORE-MISSING.
>> 
>> Not sure how much this will degrade the performance of
>> every function that uses treesit-node-match-p.
>
> It should be negligible, plus if a function wants to use a thing, it’s
> TRT to first check if the thing exists, right?

I completely agree.  So I fixed 'treesit-show-paren'
by adding a check for 'treesit-thing-defined-p'.





      reply	other threads:[~2025-01-05  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30 12:27 bug#75198: 31.0.50; [treesitter] peculiar error German Pacenza
2024-12-30 13:47 ` Andreas Kurth
2024-12-30 17:54   ` Juri Linkov
2025-01-04  8:26     ` Yuan Fu
2025-01-04 17:43       ` Juri Linkov
2025-01-04 19:22         ` Yuan Fu
2025-01-05  7:43           ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h66d9042.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=75198@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.