all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andre Spiegel <spiegel@gnu.org>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: vc.el and diff-switches containing "-r"
Date: 26 Mar 2002 20:18:08 +0100	[thread overview]
Message-ID: <87g02n3zpr.fsf@eagle.inf.fu-berlin.de> (raw)
In-Reply-To: <200203252242.RAA17002@meoptiplex.lcs.mit.edu>

Michael Ernst <mernst@alum.mit.edu> writes:

> vc.el unconditionally uses `diff-switches' (though it also concatenates
> `vc-diff-switches').  However, some switches that are sensible in
> `diff-switches' are not sensible as arguments to (say) "cvs diff".  This
> patch corrects the problem.  (Another solution would be for
> `vc-diff-switches' to override `diff-switches', if set, rather than for
> both to be used.)

Thanks for the report.  I do favour the latter approach, where
vc-diff-switches overrides diff-switches if set.  Likewise, I think
vc-cvs-diff-switches should override the other two if set, rather
than be concatenated.

I don't like the idea of treating "-r" specially as in your patch --
the same problem would be bound to come up with other options and
other backends as well.

I will change the behaviour as outlined above as soon as I find time
to rework the backend-specific variable handling, as I am planning
anyway.  It will be before the next Emacs release.  Until then, I hope
you can do with your local modification.

      reply	other threads:[~2002-03-26 19:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-25 22:42 vc.el and diff-switches containing "-r" Michael Ernst
2002-03-26 19:18 ` Andre Spiegel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87g02n3zpr.fsf@eagle.inf.fu-berlin.de \
    --to=spiegel@gnu.org \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.