Installation of bubbles.el

Installation of bubbles.el

[Ulf Jasper]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Hi,

this is bubbles.el 0.4, a puzzle game for Emacs. Earlier versions have
been posted to gnu-emacs-sources. In the meantime copyright has been
transferred to FSF and bubbles.el is ready for installation.

Would somebody please install bubbles.el?

Thanks!

Ulf


[-- Attachment #2: bubbles.el --]
[-- Type: application/emacs-lisp, Size: 47645 bytes --]

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Installation of bubbles.el

[Thien-Thi Nguyen]

() Ulf Jasper <ulf.jasper@web.de>
() Mon, 27 Aug 2007 20:19:40 +0200

   Would somebody please install bubbles.el?

i have installed it as lisp/play/bubbles.el, and
made some slight modifications.  two items remain:

 - please write a blurb for NEWS

 - i noticed some `define-key' forms at top-level.
   the pattern is like so:
     (defvar MAP INIT)
     (define-key MAP ...)
     (define-key MAP ...)
     (define-key MAP ...) ...

   i think it would be a good idea to move the defvars to the
   beginning of the file, w/ value nil, and also consolidate
   the define-key forms using the idiom:
     (unless MAP
       (let ((m INIT))
         (define-key m ...) ...))

   other ways: mapc define-key over a list, etc.

other than that, looks good!  i was glad to install it.

thi

Re: Installation of bubbles.el

[Ulf Jasper]

Thien-Thi Nguyen <ttn@gnuvola.org> writes:
> i have installed it as lisp/play/bubbles.el, and
> made some slight modifications.  two items remain:

Thank you. I'll fix it the next days.

Best,

ulf