From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sven Joachim Newsgroups: gmane.emacs.devel Subject: kill-buffer-if-not-modified: Wrong type argument: bufferp, t Date: Mon, 21 Jan 2008 19:44:37 +0100 Message-ID: <87fxwrc92i.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1200941028 30016 80.91.229.12 (21 Jan 2008 18:43:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Jan 2008 18:43:48 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 21 19:44:07 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JH1cq-0001sw-E0 for ged-emacs-devel@m.gmane.org; Mon, 21 Jan 2008 19:44:04 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH1cQ-0005hP-SU for ged-emacs-devel@m.gmane.org; Mon, 21 Jan 2008 13:43:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JH1cL-0005hI-On for emacs-devel@gnu.org; Mon, 21 Jan 2008 13:43:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JH1cI-0005h6-Bq for emacs-devel@gnu.org; Mon, 21 Jan 2008 13:43:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH1cI-0005gy-5X for emacs-devel@gnu.org; Mon, 21 Jan 2008 13:43:30 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JH1cH-0004ps-SA for emacs-devel@gnu.org; Mon, 21 Jan 2008 13:43:30 -0500 Original-Received: (qmail invoked by alias); 21 Jan 2008 18:43:27 -0000 Original-Received: from p548674F7.dip.t-dialin.net (EHLO debian) [84.134.116.247] by mail.gmx.net (mp014) with SMTP; 21 Jan 2008 19:43:27 +0100 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX1+bfRkiOhGbTS62MNsTQEih84PUedXvhRvC5FWyT0 6t3xcZP9iwrslO User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87226 Archived-At: The following change in EMACS_22_BASE: ,---- | 2008-01-12 Eli Zaretskii | | * view.el (view-file-other-window, view-file-other-frame): Don't | kill the buffer if it is modified. Doc fixes. | (kill-buffer-if-not-modified): New function. | (view-file): Don't kill the buffer if it is modified. `---- causes the error mentioned in the subject every time view-mode is exited. It seems that this patch fixes the issue: --8<---------------cut here---------------start------------->8--- --- view.el 21 Jan 2008 18:51:02 +0100 1.84.2.9 +++ view.el 21 Jan 2008 19:26:10 +0100 @@ -244,7 +244,9 @@ ;; types C-x C-q again to return to view mode. (defun kill-buffer-if-not-modified (buf) "Like `kill-buffer', but does nothing if the buffer is modified." - (let ((buf (or (bufferp buf) (get-buffer buf)))) + (let ((buf (if (bufferp buf) + buf + (get-buffer buf)))) (and buf (not (buffer-modified-p buf)) (kill-buffer buf)))) --8<---------------cut here---------------end--------------->8--- Changelog entry: 2008-01-21 Sven Joachim * view.el (kill-buffer-if-not-modified): Fix argument to kill-buffer. Eli, is switching away from the buffer even if it is modified the intended behavior?