From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: patch for Dired second header line info Date: Sun, 02 Mar 2008 04:55:28 +0200 Organization: JURTA Message-ID: <87fxv9zxqv.fsf@jurta.org> References: <000101c87b38$1dcd2db0$0600a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204428694 19181 80.91.229.12 (2 Mar 2008 03:31:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Mar 2008 03:31:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 02 04:32:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JVevg-00064H-Dc for ged-emacs-devel@m.gmane.org; Sun, 02 Mar 2008 04:32:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVev9-0007o7-RM for ged-emacs-devel@m.gmane.org; Sat, 01 Mar 2008 22:31:27 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JVetg-0006ZT-5m for emacs-devel@gnu.org; Sat, 01 Mar 2008 22:29:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JVete-0006YT-5z for emacs-devel@gnu.org; Sat, 01 Mar 2008 22:29:55 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVetd-0006YF-PI for emacs-devel@gnu.org; Sat, 01 Mar 2008 22:29:53 -0500 Original-Received: from relay02.kiev.sovam.com ([62.64.120.197]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JVetd-0002td-2N for emacs-devel@gnu.org; Sat, 01 Mar 2008 22:29:53 -0500 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JVetO-0002kU-HG; Sun, 02 Mar 2008 05:29:40 +0200 In-Reply-To: <000101c87b38$1dcd2db0$0600a8c0@us.oracle.com> (Drew Adams's message of "Fri, 29 Feb 2008 17:03:52 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-unknown-linux-gnu) X-Scanner-Signature: d0b3bc0b24c4067239780ad28ae5b444 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2346 [Feb 29 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 11 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91029 Archived-At: > The second header line in a Dired buffer currently looks like this: > > total used in directory 49439 available 56233408 > > Attached is a patch (for `files.el' and `ls-lisp.el') that changes that text > to this: > > files 691 space used 49439 available 56233408 Are you sure this change will not break other packages that rely on the first word `total' at the beginning of a dired buffer? It seems it would be safer to leave it as is, and add new information to the end of this line like: total used in directory 49439 available 56233408 files 691 Also I think instead of displaying the number of files listed in the current dired buffer, more useful would be to display the total number of files in the current directory. There are features that hide files in the dired buffer (e.g. dired-omit-mode), so displaying the total number of files will be helpful for users to see that there are more hidden files. This also will simplify the implementation of the feature you propose, so instead of a new function `count-dired-files' you can just use (length (directory-files dir nil t)) -- Juri Linkov http://www.jurta.org/emacs/