From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: bug#636: Please fix before the release of 23.1 Date: Mon, 11 Aug 2008 12:30:04 -0400 Message-ID: <87fxpb5xbn.fsf@stupidchicken.com> References: <877ibp4hh3.fsf@vorlon.ganneff.de> <871w1xfmsb.fsf@grepfind.mwolson.org> <87ljzj3oad.fsf_-_@grepfind.mwolson.org> <18590.45488.891078.545308@a1ihome1.kph.uni-mainz.de> <18590.47471.82980.734389@a1ihome1.kph.uni-mainz.de> <87ljz45xfj.fsf@stupidchicken.com> <18591.59359.40969.641357@a1ihome1.kph.uni-mainz.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218472484 19282 80.91.229.12 (11 Aug 2008 16:34:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Aug 2008 16:34:44 +0000 (UTC) Cc: Glenn Morris , Michael Olson , 636@emacsbugs.donarmstrong.com, Alan Mackenzie , emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 11 18:35:35 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KSaMp-0006yw-A4 for ged-emacs-devel@m.gmane.org; Mon, 11 Aug 2008 18:35:35 +0200 Original-Received: from localhost ([127.0.0.1]:57190 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSaLt-00039a-1s for ged-emacs-devel@m.gmane.org; Mon, 11 Aug 2008 12:34:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSaHI-0006xU-KP for emacs-devel@gnu.org; Mon, 11 Aug 2008 12:29:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSaHG-0006uv-Pp for emacs-devel@gnu.org; Mon, 11 Aug 2008 12:29:52 -0400 Original-Received: from [199.232.76.173] (port=34331 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSaHG-0006ui-JT for emacs-devel@gnu.org; Mon, 11 Aug 2008 12:29:50 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:60150 helo=cyd) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KSaH5-0000S9-Ts; Mon, 11 Aug 2008 12:29:40 -0400 Original-Received: by cyd (Postfix, from userid 1000) id 1E76E57E1CA; Mon, 11 Aug 2008 12:30:04 -0400 (EDT) In-Reply-To: <18591.59359.40969.641357@a1ihome1.kph.uni-mainz.de> (Ulrich Mueller's message of "Mon, 11 Aug 2008 09:18:55 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102289 Archived-At: Ulrich Mueller writes: >> (defconst foo >> (let ((beginning-of-defun-function >> (lambda (&optional arg) >> (not (eq arg nil))))) >> (progn >> (beginning-of-defun 1)))) > >> (provide 'foo) > > Calling beginning-of-defun will move point, right? > > And since beginning-of-defun-function is essentially defined as a > no-op, point will just be moved to the beginning-of-line. (In fact, > eval-buffer on foo.el results in an infinite loop.) Aha, I see. So the question is, should we make the change to cc-defs.el, or (as suggested by Michael Olson) make the byte-compiler wrap around each variable definition with `save-excursion'? Even with the latter solution, incorrectly written elisp in variable definitions can still create problems. For example, `save-excursion' won't save us if the elisp runs `kill-buffer'. This indicates that we fix cc-defs.el, and leave the rest of Emacs alone.