From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#1233: rcirc fill-region bugfix Date: Thu, 23 Oct 2008 18:04:50 -0400 Message-ID: <87fxmnrmrh.fsf@cyd.mit.edu> Reply-To: Chong Yidong , 1233@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224801062 30805 80.91.229.12 (23 Oct 2008 22:31:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Oct 2008 22:31:02 +0000 (UTC) Cc: 1233@emacsbugs.donarmstrong.com To: Ryan Yeske Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 24 00:32:00 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kt8ik-00051I-Ao for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Oct 2008 00:31:59 +0200 Original-Received: from localhost ([127.0.0.1]:36799 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kt8hd-0001hN-Oz for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Oct 2008 18:30:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kt8h9-0001XK-7g for bug-gnu-emacs@gnu.org; Thu, 23 Oct 2008 18:30:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kt8h5-0001Vt-Ud for bug-gnu-emacs@gnu.org; Thu, 23 Oct 2008 18:30:18 -0400 Original-Received: from [199.232.76.173] (port=57131 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kt8h5-0001Vq-R7 for bug-gnu-emacs@gnu.org; Thu, 23 Oct 2008 18:30:15 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42828) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kt8h5-0003p5-2a for bug-gnu-emacs@gnu.org; Thu, 23 Oct 2008 18:30:15 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9NMU1v6007993; Thu, 23 Oct 2008 15:30:02 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9NMA4XA003278; Thu, 23 Oct 2008 15:10:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 23 Oct 2008 22:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1233 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Original-Received: via spool by 1233-submit@emacsbugs.donarmstrong.com id=B1233.12247994901168 (code B ref 1233); Thu, 23 Oct 2008 22:10:04 +0000 Original-Received: (at 1233) by emacsbugs.donarmstrong.com; 23 Oct 2008 22:04:50 +0000 Original-Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9NM4l51001162 for <1233@emacsbugs.donarmstrong.com>; Thu, 23 Oct 2008 15:04:48 -0700 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 89A9257E055; Thu, 23 Oct 2008 18:04:50 -0400 (EDT) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 23 Oct 2008 18:30:18 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21842 Archived-At: Hi Ryan, Could you review this patch? Jeff Makey wrote: > When a message begins with a very long word (typically a URL), rcirc > in Emacs 22 inserts a useless newline like this: > > 08:10 > http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html > has this month's archives > > The patch below excludes the timestamp and nick from the beginning of > the filled region, which will cause such a line to be shown in this > more compact format: > > 08:10 http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html > has this month's archives --- rcirc.el.orig 2008-02-10 06:03:53 -0800 +++ rcirc.el 2008-10-08 23:33:57 -0700 @@ -1251,7 +1251,7 @@ (rcirc-fill-column rcirc-fill-column) (t fill-column)))) - (fill-region fill-start rcirc-prompt-start-marker 'left t))))) + (fill-region text-start rcirc-prompt-start-marker 'left t))))) ;; set inserted text to be read-only (when rcirc-read-only-flag