From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#4219: 23.1; case insensitive + partial completions Date: Fri, 11 Sep 2009 21:23:20 -0400 Message-ID: <87fxatq7lj.fsf@stupidchicken.com> Reply-To: Chong Yidong , 4219@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1252720047 13709 80.91.229.12 (12 Sep 2009 01:47:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Sep 2009 01:47:27 +0000 (UTC) Cc: Eli Barzilay , 4219@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 12 03:47:20 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MmHht-0005qP-MV for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Sep 2009 03:47:18 +0200 Original-Received: from localhost ([127.0.0.1]:53139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmHht-0007fc-2H for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Sep 2009 21:47:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmHhn-0007dF-VO for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2009 21:47:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmHhj-0007c5-9Z for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2009 21:47:11 -0400 Original-Received: from [199.232.76.173] (port=53403 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmHhj-0007bz-5u for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2009 21:47:07 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:59637) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MmHhi-0005k7-HQ for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2009 21:47:06 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8C1kxeP012857; Fri, 11 Sep 2009 18:46:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8C1U4WO009934; Fri, 11 Sep 2009 18:30:04 -0700 Resent-Date: Fri, 11 Sep 2009 18:30:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 12 Sep 2009 01:30:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4219 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4219-submit@emacsbugs.donarmstrong.com id=B4219.12527186078935 (code B ref 4219); Sat, 12 Sep 2009 01:30:04 +0000 Original-Received: (at 4219) by emacsbugs.donarmstrong.com; 12 Sep 2009 01:23:27 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from pantheon-po45.its.yale.edu (pantheon-po45.its.yale.edu [130.132.50.79]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8C1NQ4l008927 for <4219@emacsbugs.donarmstrong.com>; Fri, 11 Sep 2009 18:23:27 -0700 Original-Received: from furry (dhcp128036014244.central.yale.edu [128.36.14.244]) (authenticated bits=0) by pantheon-po45.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n8C1NKqn009860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 11 Sep 2009 21:23:20 -0400 Original-Received: by furry (Postfix, from userid 1000) id 5CBE7C070; Fri, 11 Sep 2009 21:23:20 -0400 (EDT) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 11 Sep 2009 21:47:11 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30987 Archived-At: > Start with a default Emacs, and > > (setq read-file-name-completion-ignore-case t) > (setq completion-styles '(partial-completion)) > > Now go to a directory that has two files called > > INSTALL > install-sh > > Hit `C-x C-f ins TAB' -- it will be completed to "insTALL". Stefan, could you take a look at this? I glanced through your partial completion code, and it's clear where the problem arises. In completion-pcm--merge-try, (completion-pcm--merge-completions all pattern) returns (all "TALL" "ins") and so completion-pcm--pattern->string naively joins the result into "insTALL". However, I don't know how to fix this. The default completion style actually does the right thing, because it can just replace the string wholesale, but I'm not sure if the pcm style can do the same thing.