From: Juri Linkov <juri@jurta.org>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 4677@emacsbugs.donarmstrong.com
Subject: bug#4677: allow VC operations from dired
Date: Wed, 14 Oct 2009 01:38:47 +0300 [thread overview]
Message-ID: <87fx9mx640.fsf@mail.jurta.org> (raw)
In-Reply-To: <200910122051.n9CKpXKh003942@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 12 Oct 2009 13:51:33 -0700 (PDT)")
> > > > > This patch allows VC operations to be run from dired.
> > > > > State changing VC operations are not supported.
> > > > > (only the various variations of log and diff)
> > > >
> > > > Thanks, it works right except in one case: when called outside of
> > > > a repository controlled directory, it traverses all subdirectories
> > > > trying to find a repository (I think traversing subdirectories
> > > > makes no sense in this case) and later fails with:
> > > >
> > > > Wrong type argument: stringp, nil
> > >
> > > Thanks. Here's an updated patch.
> >
> > Hmm, now it fails with "Directory not under VC" in all directories
> > even under version control since (vc-backend default-directory)
> > always returns nil.
>
> Hmm, I should have said "not really tested".
> I guess the first version will have to do then.
I see that (vc-backend default-directory) works for directories in CVS,
but always returns nil for git (is it because git is file-oriented?).
OTOH, (vc-call-backend 'git 'root default-directory) works for git,
but (vc-call-backend 'cvs 'root default-directory) fails with
"Sorry, root is not implemented for cvs"
I can't find a generic function that would work for directories
in all backends.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-10-13 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200911201637.nAKGb9go024620@godzilla.ics.uci.edu>
2009-10-08 20:19 ` bug#4677: allow VC operations from dired Dan Nicolaescu
2009-10-11 23:55 ` Juri Linkov
2009-10-12 2:46 ` Dan Nicolaescu
2009-10-12 20:27 ` Juri Linkov
2009-10-12 20:51 ` Dan Nicolaescu
2009-10-13 22:38 ` Juri Linkov [this message]
2009-10-13 23:22 ` Dan Nicolaescu
2009-10-23 18:21 ` Dan Nicolaescu
2009-11-19 16:50 ` Dan Nicolaescu
2009-11-19 21:08 ` Stefan Monnier
2009-11-20 16:45 ` bug#4677: marked as done (allow VC operations from dired) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fx9mx640.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=4677@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.