From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#5477: 23.1.91; diary-unhide-everything sometimes doesn't Date: Tue, 26 Jan 2010 22:05:00 +0100 Message-ID: <87fx5s60hv.fsf@escher.home> References: <87fx5tuap4.fsf@escher.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264540214 15929 80.91.229.12 (26 Jan 2010 21:10:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jan 2010 21:10:14 +0000 (UTC) Cc: 5477@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 26 22:10:06 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NZsfh-0003YJ-Cq for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2010 22:10:01 +0100 Original-Received: from localhost ([127.0.0.1]:48882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZsfi-0001gD-Mi for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2010 16:10:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZsfd-0001cu-7R for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2010 16:09:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZsfY-0001XL-MJ for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2010 16:09:56 -0500 Original-Received: from [199.232.76.173] (port=34110 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZsfY-0001XB-FC for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2010 16:09:52 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49195) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZsfX-0003ve-Q2 for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2010 16:09:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NZsbq-0005J9-Kj; Tue, 26 Jan 2010 16:06:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Stephen Berman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jan 2010 21:06:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5477 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5477-submit@debbugs.gnu.org id=B5477.126453994520386 (code B ref 5477); Tue, 26 Jan 2010 21:06:02 +0000 Original-Received: (at 5477) by debbugs.gnu.org; 26 Jan 2010 21:05:45 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZsbY-0005Il-7x for submit@debbugs.gnu.org; Tue, 26 Jan 2010 16:05:44 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1NZsbV-0005Ib-W2 for 5477@debbugs.gnu.org; Tue, 26 Jan 2010 16:05:43 -0500 Original-Received: (qmail invoked by alias); 26 Jan 2010 21:05:22 -0000 Original-Received: from i59F559EF.versanet.de (EHLO escher.home) [89.245.89.239] by mail.gmx.net (mp009) with SMTP; 26 Jan 2010 22:05:22 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1+hwIsqmVmhdEuK4i+lsG4oSCcT2F7NTFkjIvERz3 OdgcadgSP2lLdz Original-Received: by escher.home (Postfix, from userid 1000) id A6D8B10348; Tue, 26 Jan 2010 22:05:00 +0100 (CET) In-Reply-To: (Glenn Morris's message of "Tue, 26 Jan 2010 15:21:32 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.59999999999999998 X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -3.3 (---) Resent-Date: Tue, 26 Jan 2010 16:06:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34731 Archived-At: On Tue, 26 Jan 2010 15:21:32 -0500 Glenn Morris wrote: > Stephen Berman wrote: > >> (defun diary-unhide-everything () >> "Show all invisible text in the diary." >> (kill-local-variable 'diary-selective-display) >> ! (save-excursion >> ! (save-restriction >> ! (widen) >> ! (remove-overlays (point-min) (point-max) 'invisible 'diary))) >> (kill-local-variable 'mode-line-format)) > > This seems fine. Is your save-excursion really necessary? No, it's superfluous, sorry. That nesting is so common, I didn't stop to think. Thanks for the heads up. Steve Berman *** /tmp/ediff3766uVW 2010-01-26 21:56:24.000000000 +0100 --- /home/steve/bzr/emacs/quickfixes/lisp/calendar/diary-lib.el 2010-01-26 21:55:19.000000000 +0100 *************** *** 804,810 **** (defun diary-unhide-everything () "Show all invisible text in the diary." (kill-local-variable 'diary-selective-display) ! (remove-overlays (point-min) (point-max) 'invisible 'diary) (kill-local-variable 'mode-line-format)) (defvar original-date) ; bound in diary-list-entries --- 804,812 ---- (defun diary-unhide-everything () "Show all invisible text in the diary." (kill-local-variable 'diary-selective-display) ! (save-restriction ! (widen) ! (remove-overlays (point-min) (point-max) 'invisible 'diary)) (kill-local-variable 'mode-line-format)) (defvar original-date) ; bound in diary-list-entries