[Bug] html-export mangels mailto: links

[Bug] html-export mangels mailto: links

[Achim Gratz]

HTML export removes the "mailto:" from a link, which will then be
interpreted as a local link by the browser.

For an example, see the link to this mailing list in
ORGWEBPAGE/index.org and the corresponding HTML export on orgmode-org
(or just the local file).


Achim.

[PATCH] Re: html-export mangels mailto: links

[Noorul Islam K M]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

Achim Gratz <Stromeko@nexgo.de> writes:

> HTML export removes the "mailto:" from a link, which will then be
> interpreted as a local link by the browser.
>
> For an example, see the link to this mailing list in
> ORGWEBPAGE/index.org and the corresponding HTML export on orgmode-org
> (or just the local file).
>

org-html.el : Fix exporting file, mailto, news and ftp protocols.

* lisp/org-html.el (org-html-make-link): (expand-file-name
) removes one "/" from "///path-to-file", so add one. Anything other
than 'file' type should be exported along with the type.

TINYCHANGE

Thanks and Regards
Noorul


[-- Attachment #2: org-html.el.txt --]
[-- Type: text/plain, Size: 813 bytes --]

diff --git a/lisp/org-html.el b/lisp/org-html.el
index 099b2e3..4430768 100644
--- a/lisp/org-html.el
+++ b/lisp/org-html.el
@@ -720,7 +720,7 @@ MAY-INLINE-P allows inlining it as an image."
 			   ;;Substitute just if original path was absolute.
 			   ;;(Otherwise path must remain relative)
 			   (if (file-name-absolute-p path)
-			      (expand-file-name path)
+			      (concat "/" (expand-file-name path))
 			      path)))
 		     ((string= type "")
 			(list nil path))
@@ -756,8 +756,7 @@ MAY-INLINE-P allows inlining it as an image."
 	 (setq thefile
 	    (let
 	       ((str (org-export-html-format-href thefile)))
-	      (if (and type (not (string= "file" type))
-		       (org-string-match-p "^//" str))
+	      (if (and type (not (string= "file" type)))
 		  (concat type ":" str)
 		  str)))
 

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

[Accepted] Re: html-export mangels mailto: links

[Bastien Guerry]

Patch 251 (http://patchwork.newartisans.com/patch/251/) is now "Accepted".

Maintainer comment: Applied a slightly modified version: better handling of absolute filenames.

This relates to the following submission:

http://mid.gmane.org/%3C87iq2o3b5s.fsf%40noorul.maa.corp.collab.net%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: html-export mangels mailto: links
> Date: Thu, 02 Sep 2010 11:35:43 -0000
> From: Noorul Islam <noorul@noorul.com>
> X-Patchwork-Id: 251
> Message-Id: <87iq2o3b5s.fsf@noorul.maa.corp.collab.net>
> To: Achim Gratz <Stromeko@nexgo.de>
> Cc: emacs-orgmode@gnu.org
> 
> Achim Gratz <Stromeko@nexgo.de> writes:
> 
> > HTML export removes the "mailto:" from a link, which will then be
> > interpreted as a local link by the browser.
> >
> > For an example, see the link to this mailing list in
> > ORGWEBPAGE/index.org and the corresponding HTML export on orgmode-org
> > (or just the local file).
> >
> 
> org-html.el : Fix exporting file, mailto, news and ftp protocols.
> 
> * lisp/org-html.el (org-html-make-link): (expand-file-name
> ) removes one "/" from "///path-to-file", so add one. Anything other
> than 'file' type should be exported along with the type.
> 
> TINYCHANGE
> 
> Thanks and Regards
> Noorul
> 
> 
> diff --git a/lisp/org-html.el b/lisp/org-html.el
> index 099b2e3..4430768 100644
> --- a/lisp/org-html.el
> +++ b/lisp/org-html.el
> @@ -720,7 +720,7 @@ MAY-INLINE-P allows inlining it as an image."
>  			   ;;Substitute just if original path was absolute.
>  			   ;;(Otherwise path must remain relative)
>  			   (if (file-name-absolute-p path)
> -			      (expand-file-name path)
> +			      (concat "/" (expand-file-name path))
>  			      path)))
>  		     ((string= type "")
>  			(list nil path))
> @@ -756,8 +756,7 @@ MAY-INLINE-P allows inlining it as an image."
>  	 (setq thefile
>  	    (let
>  	       ((str (org-export-html-format-href thefile)))
> -	      (if (and type (not (string= "file" type))
> -		       (org-string-match-p "^//" str))
> +	      (if (and type (not (string= "file" type)))
>  		  (concat type ":" str)
>  		  str)))
>  
> 

Re: [PATCH] Re: html-export mangels mailto: links

[Bastien]

Noorul Islam K M <noorul@noorul.com> writes:

> org-html.el : Fix exporting file, mailto, news and ftp protocols.
>
> * lisp/org-html.el (org-html-make-link): (expand-file-name
> ) removes one "/" from "///path-to-file", so add one. Anything other
> than 'file' type should be exported along with the type.

I applied it -- thanks.

I modified it further so that absolute filenames are exported as
"file:///filename" links.

-- 
 Bastien

Re: [PATCH] Re: html-export mangels mailto: links

[Achim Gratz]

These two commits break exporting of local links as reported elsewhere
on this list.

Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada

Re: Re: [PATCH] Re: html-export mangels mailto: links

[David Maus]

[-- Attachment #1.1: Type: text/plain, Size: 273 bytes --]

Achim Gratz wrote:
>These two commits break exporting of local links as reported elsewhere
>on this list.

The problem with exporting local links is fixed in master.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] Re: html-export mangels mailto: links

[Achim Gratz]

David Maus <dmaus@ictsoc.de> writes:
> The problem with exporting local links is fixed in master.

Thanks, although I don't see that particular commit yet... :-)

One other question: I often see org-mode version reported like this:

Org-mode version 7.01trans (release_7.01h.497.g59fa)

All I get is 7.01trans sans the "release" part, is there some makefile
target I'm missing or some configuration to extend the version string
that org-mode reports?


Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Re: Re: [PATCH] Re: html-export mangels mailto: links

[Eric S Fraga]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Sun, 12 Sep 2010 21:23:23 +0200, Achim Gratz <Stromeko@nexgo.de> wrote:
> 
> David Maus <dmaus@ictsoc.de> writes:
> > The problem with exporting local links is fixed in master.
> 
> Thanks, although I don't see that particular commit yet... :-)
> 
> One other question: I often see org-mode version reported like this:
> 
> Org-mode version 7.01trans (release_7.01h.497.g59fa)
> 
> All I get is 7.01trans sans the "release" part, is there some makefile
> target I'm missing or some configuration to extend the version string
> that org-mode reports?

it's the output of "M-x org-version RET" as opposed to the value of
org-version.

[-- Attachment #2: Type: text/plain, Size: 75 bytes --]

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] Re: html-export mangels mailto: links

[Achim Gratz]

Eric S Fraga <ucecesf@ucl.ac.uk> writes:
> it's the output of "M-x org-version RET" as opposed to the value of
> org-version.

They both deliver the same result "7.01trans" for me, that's why I'm
asking...

Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: Re: [PATCH] Re: html-export mangels mailto: links

[Nick Dokos]

Achim Gratz <Stromeko@nexgo.de> wrote:

> Eric S Fraga <ucecesf@ucl.ac.uk> writes:
> > it's the output of "M-x org-version RET" as opposed to the value of
> > org-version.
> 
> They both deliver the same result "7.01trans" for me, that's why I'm
> asking...
> 

org-version makes some assumptions: it calculates a directory as follows

   (concat (file-name-directory (locate-library "org")) "../" ))

and then looks for a ``.git'' subdirectory in that directory. If it is
found, then all is good: it does a ``git describe'' variation to get the
release part.  But if it is not found, then it falls back to the bare
version (without the release part).

E.g. if you git pull into one place and then install the .el files
somewhere else, the .git subdirectory will not be found.

So evaluate these two expressions:

(setq dir (concat (file-name-directory (locate-library "org")) "../" )))
(file-exists-p (expand-file-name ".git" dir))

and you'll probably find that the second one returns nil in your case.

One way to get the release part: arrange your load-path to load org.el[c]
(and the other org .el or .elc files) from the lisp subdirectory of your
git repository.

HTH,
Nick

Re: [PATCH] Re: html-export mangels mailto: links

[Achim Gratz]

Nick Dokos <nicholas.dokos@hp.com> writes:
[...]
> E.g. if you git pull into one place and then install the .el files
> somewhere else, the .git subdirectory will not be found.

Thanks for the explanation, I do indeed have the source in one place and
then just proceed to "make install" into my site-lisp directory.  I'll
see how to modify my load-path a bit differently to accommodate this
slightly different workflow that org assumes.


Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: [PATCH] Re: html-export mangels mailto: links

[Achim Gratz]

I've decided to keep my standard load-path. Instead I just put

(setq load-path (cons (expand-file-name "~/lisp/org-mode/user-lisp") load-path))
(setq load-path (cdr load-path))

in the scratch buffer and execute one line or the other whenever I want
to switch and then do a C-c C-x ! in an org-buffer.  That way I can keep
a clean install in site-lisp.  I might make these two lines into
functions I can call directly from org-mode (and bind to keys), but for
now that's working well enough to be no bother.

Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves