[PATCH] isearch: Propertize error messages

[PATCH] isearch: Propertize error messages

[Andrew Helsley]

This patches enhances the visual contrast between the search expression 
and any error messages that show at the end of the line in `isearch-mode'.

--------
regards,
Andrew Helsley


diff -r -c emacs-1/lisp/ChangeLog emacs-2/lisp/ChangeLog
*** emacs-1/lisp/ChangeLog	2010-11-21 23:17:59.000000000 -0800
--- emacs-2/lisp/ChangeLog	2010-11-21 23:17:33.000000000 -0800
***************
*** 1,3 ****
--- 1,6 ----
+ 2010-11-21  Andrew Helsley  <helsleya@cs.ucr.edu>
+ 	* isearch.el (isearch-message-suffix): Propertize error messages.
+
   2010-11-21  Michael Albinus  <michael.albinus@gmx.de>

   	* files.el (backup-by-copying-when-mismatch): The default value is
diff -r -c emacs-1/lisp/isearch.el emacs-2/lisp/isearch.el
*** emacs-1/lisp/isearch.el	2010-11-21 22:57:58.000000000 -0800
--- emacs-2/lisp/isearch.el	2010-11-21 23:11:58.000000000 -0800
***************
*** 257,262 ****
--- 257,268 ----
     :version "23.1"
     :group 'isearch)

+ (defface isearch-error-message
+   '((t (:inherit font-lock-warning-face)))
+   "Face for highlighting error messages in Isearch echo area."
+   :group 'isearch
+   :group 'basic-faces)
+
   (defcustom isearch-lazy-highlight t
     "Controls the lazy-highlighting during incremental search.
   When non-nil, all text in the buffer matching the current search
***************
*** 2188,2194 ****
   (defun isearch-message-suffix (&optional c-q-hack ellipsis)
     (concat (if c-q-hack "^Q" "")
   	  (if isearch-error
! 	      (concat " [" isearch-error "]")
   	    "")
   	  (or isearch-message-suffix-add "")))

--- 2194,2201 ----
   (defun isearch-message-suffix (&optional c-q-hack ellipsis)
     (concat (if c-q-hack "^Q" "")
   	  (if isearch-error
! 	      (propertize (concat " [" isearch-error "]")
! 			  'face 'isearch-error-message)
   	    "")
   	  (or isearch-message-suffix-add "")))

Re: [PATCH] isearch: Propertize error messages

[Juri Linkov]

> This patches enhances the visual contrast between the search expression and
> any error messages that show at the end of the line in `isearch-mode'.

Thanks, I think it's a good change to highlight the error message.