From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH] org-agenda: rework ndays and span handling Date: Thu, 02 Dec 2010 21:11:02 -0500 Message-ID: <87fwufhah5.fsf@gollum.intra.norang.ca> References: <1291027797-22612-1-git-send-email-julien@danjou.info> <870C3B1D-3360-4B23-BCEA-DA88715FEF25@gmail.com> <87fwuhwt1p.fsf@pinto.chemeng.ucl.ac.uk> <87mxopiqqi.fsf@keller.adm.naquadah.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=46521 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POL7D-0000L3-Ff for emacs-orgmode@gnu.org; Thu, 02 Dec 2010 21:11:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POL7C-0005FR-9X for emacs-orgmode@gnu.org; Thu, 02 Dec 2010 21:11:15 -0500 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:37766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POL7C-0005Et-7s for emacs-orgmode@gnu.org; Thu, 02 Dec 2010 21:11:14 -0500 In-Reply-To: <87mxopiqqi.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Wed, 01 Dec 2010 14:09:57 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Julien Danjou Cc: Eric S Fraga , emacs-orgmode@gnu.org, Carsten Dominik Julien Danjou writes: > On Wed, Dec 01 2010, Eric S Fraga wrote: > >> Mostly works fine but there is one problem I have encountered. If you >> change your view (mine defaults to day so I sometimes switch to week >> view), you can go forward and backward as expected. However, if you >> /jump/ (j in agenda view) to a given date, the view resets to the >> default (well, to single day view in my case). I prefer the view to >> remain as I have specified it last until I change it myself. > > Good catch. Patch updated fixing that. Hi Julien, I tried your patch out tonight and I'm confused about org-agenda-ndays. This is stated as obsolete (since 24.1 ? what's that?) but the default for org-agenda-span doesn't seem to be set based on the existing value of org-agenda-ndays. Is that on purpose? I'm fine with customizing org-agenda-span as long as it's documented that this needs to be done for the next version of org-mode that includes your patch. I also noticed the display on the modeline says 'Day', 'Week', 'Month', or 'Year' when displaying the agenda with 'd', 'w', 'v m', and 'v y' which is great. However this data is lost and replaced with '1 days' if moving forwards or backwards in the agenda with 'f' and 'b' or jumping to a date with 'j'. Otherwise I think this looks good to me. Regards, Bernt