Re: /srv/bzr/emacs/trunk r104968: Fix some uses of switch-to-buffer.

all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed

* Re: /srv/bzr/emacs/trunk r104968: Fix some uses of switch-to-buffer.
       [not found] <E1Qe8JJ-0000Xj-0a@colonialone.fsf.org>
@ 2011-07-05 20:00 ` Michael Albinus
  2011-07-06  1:08   ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2011-07-05 20:00 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

Hi Stefan,

> ------------------------------------------------------------
> revno: 104968
> committer: Stefan Monnier <monnier@iro.umontreal.ca>
> branch nick: trunk
> timestamp: Tue 2011-07-05 11:31:22 -0400
> message:
>   Fix some uses of switch-to-buffer.
>   * lisp/net/tramp-cmds.el (tramp-append-tramp-buffers):

I'm sorry, but this causes trouble to Tramp. `pop-to-buffer-same-window'
does not exist outside Emacs 24. And the underlying `pop-to-buffer' is
not compatible with XEmacs, at least.

I would like to revert this change for tramp-cmds.el. WDYT?

Best regards, Michael.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: /srv/bzr/emacs/trunk r104968: Fix some uses of switch-to-buffer.
  2011-07-05 20:00 ` /srv/bzr/emacs/trunk r104968: Fix some uses of switch-to-buffer Michael Albinus
@ 2011-07-06  1:08   ` Stefan Monnier
  2011-07-06  9:51     ` Michael Albinus
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2011-07-06  1:08 UTC (permalink / raw)
  To: Michael Albinus; +Cc: emacs-devel

>> * lisp/net/tramp-cmds.el (tramp-append-tramp-buffers):

> I'm sorry, but this causes trouble to Tramp. `pop-to-buffer-same-window'
> does not exist outside Emacs 24. And the underlying `pop-to-buffer' is
> not compatible with XEmacs, at least.

> I would like to revert this change for tramp-cmds.el. WDYT?

switch-to-buffer is wrong since it'll fail in some cases.
I'll let you decide what's the best backward compatibility approach to
use for Tramp, but reverting the change would be a bad idea.


        Stefan



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: /srv/bzr/emacs/trunk r104968: Fix some uses of switch-to-buffer.
  2011-07-06  1:08   ` Stefan Monnier
@ 2011-07-06  9:51     ` Michael Albinus
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Albinus @ 2011-07-06  9:51 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> switch-to-buffer is wrong since it'll fail in some cases.
> I'll let you decide what's the best backward compatibility approach to
> use for Tramp, but reverting the change would be a bad idea.

I've ended up in writing a compatibility function.

>         Stefan

Best regards, Michael.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-07-06  9:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1Qe8JJ-0000Xj-0a@colonialone.fsf.org>
2011-07-05 20:00 ` /srv/bzr/emacs/trunk r104968: Fix some uses of switch-to-buffer Michael Albinus
2011-07-06  1:08   ` Stefan Monnier
2011-07-06  9:51     ` Michael Albinus

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.