From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#12705: 24.2.50; `Info-complete-menu-item' should use `add-to-list', not `push', to prevent duplicates Date: Mon, 29 Oct 2012 18:44:36 +0800 Message-ID: <87fw4xd0bv.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1351507561 5908 80.91.229.3 (29 Oct 2012 10:46:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Oct 2012 10:46:01 +0000 (UTC) Cc: 12705-done@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 29 11:46:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TSmr6-0005w8-IT for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Oct 2012 11:46:04 +0100 Original-Received: from localhost ([::1]:60351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSmqy-0001e0-GQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Oct 2012 06:45:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSmqo-0001bl-Qq for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2012 06:45:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSmqg-0004vt-9b for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2012 06:45:46 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSmqg-0004vo-68 for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2012 06:45:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TSmt1-0005gS-3a for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2012 06:48:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Oct 2012 10:48:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12705 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12705-done@debbugs.gnu.org id=D12705.135150763221758 (code D ref 12705); Mon, 29 Oct 2012 10:48:03 +0000 Original-Received: (at 12705-done) by debbugs.gnu.org; 29 Oct 2012 10:47:12 +0000 Original-Received: from localhost ([127.0.0.1]:37480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSmsB-0005et-Sf for submit@debbugs.gnu.org; Mon, 29 Oct 2012 06:47:12 -0400 Original-Received: from mail-da0-f44.google.com ([209.85.210.44]:58898) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSms8-0005el-Rs for 12705-done@debbugs.gnu.org; Mon, 29 Oct 2012 06:47:09 -0400 Original-Received: by mail-da0-f44.google.com with SMTP id h15so2280290dan.3 for <12705-done@debbugs.gnu.org>; Mon, 29 Oct 2012 03:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=npemKgCZ9AD8WtZJd3qudqExOoU6wNUUzOOCx2mDPeQ=; b=tv6p/UQFCSAHu40rv10GreuaQWhYaweTRSgjsyOVtKxus0L5Wi0xmM92m+At7RElUD awgsZQf6XZ+lZVDZkxtkjZBOeeRqxm/VReIcNJSl6MZErEWx4XoKOXqPSyj7cCcYLfDu knAgRHh5xy7do94TCkw1qVFxhyXL4FDMSKwGUV7G7f10Xx1Y1nevEdWiweySZOH+OkqU D5v86RciVEaYVKfBsV4++h4zf+uOiqvAA9hSLkjuydWujjuOjKTXIr3I/U9n86xAMkGu +kUSddLJTvFsee2wwfYECZYkfFzVYCLOHpxN0e4cmfgIVXnWOJGjz+tylSDhY8DhOGsc BJWA== Original-Received: by 10.68.196.170 with SMTP id in10mr92548107pbc.0.1351507482820; Mon, 29 Oct 2012 03:44:42 -0700 (PDT) Original-Received: from ulysses ([155.69.16.22]) by mx.google.com with ESMTPS id e9sm5759882paz.28.2012.10.29.03.44.39 (version=SSLv3 cipher=OTHER); Mon, 29 Oct 2012 03:44:41 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Mon, 22 Oct 2012 09:25:56 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66183 Archived-At: "Drew Adams" writes: > This sexp: > (push (match-string-no-properties 1) completions) > > should be changed to this: > (add-to-list 'completions (match-string-no-properties 1)) > > Otherwise the same entry can be added to `completions' multiple times. > > This might not be manifested in *Completions*, because Emacs removes > duplicate candidates. But in other completion setups (e.g. Icicles) > duplicate candidates (e.g. same display string, but perhaps different > alist elements) are sometimes allowed. Sounds reasonable. Done in trunk, using delete-dups instead of add-to-list (in case info.el switches to lexical binding).