From: Michael Albinus <michael.albinus@gmx.de>
To: "Jürgen Hötzel" <juergen@archlinux.org>
Cc: emacs-devel@gnu.org
Subject: Re: make eshell-path-env buffer-local
Date: Tue, 08 Jan 2013 15:25:02 +0100 [thread overview]
Message-ID: <87fw2bg3b5.fsf@gmx.de> (raw)
In-Reply-To: <CANmXxHPHD4_HC5bF_RF+LqiQU8kPJBUcSc4uXABU2Q5xv=OscQ@mail.gmail.com> ("Jürgen Hötzel"'s message of "Tue, 8 Jan 2013 15:07:31 +0100")
Jürgen Hötzel <juergen@archlinux.org> writes:
> Hi,
Hi Juergen,
> this is required when running multiple Eshell buffers on different
> Hosts: To prevent garbling the different PATHs.
>
> Any objections against this commit?
>
> lisp/tramp.el | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/lisp/tramp.el b/lisp/tramp.el
> index f8db03e..e333ad0 100644
> --- a/lisp/tramp.el
> +++ b/lisp/tramp.el
> @@ -3896,14 +3896,14 @@ Only works for Bourne-like shells."
> ;; when `default-directory' points to another host.
> (defun tramp-eshell-directory-change ()
> "Set `eshell-path-env' to $PATH of the host related to `default-directory'."
> - (setq eshell-path-env
> - (if (file-remote-p default-directory)
> - (with-parsed-tramp-file-name default-directory nil
> - (mapconcat
> - 'identity
> - (tramp-get-connection-property v "remote-path" nil)
> - ":"))
> - (getenv "PATH"))))
> + (set (make-local-variable 'eshell-path-env)
> + (if (file-remote-p default-directory)
> + (with-parsed-tramp-file-name default-directory nil
> + (mapconcat
> + 'identity
> + (tramp-get-connection-property v "remote-path" nil)
> + ":"))
> + (getenv "PATH"))))
>
> (eval-after-load "esh-util"
> '(progn
Wouldn't it be more consistent to declare `eshell-path-env' buffer-local
in esh-util.el?
[Sorry to react late; I haven't seen the proposed patch before]
> Jürgen
Best regards, Michael.
next prev parent reply other threads:[~2013-01-08 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 14:07 make eshell-path-env buffer-local Jürgen Hötzel
2013-01-08 14:25 ` Michael Albinus [this message]
2013-01-08 14:53 ` Jürgen Hötzel
2013-01-08 15:11 ` Michael Albinus
2013-01-08 17:19 ` Jürgen Hötzel
2013-01-17 10:05 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw2bg3b5.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=juergen@archlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.