From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#12615: 24.2.50; Non-ignored case in insert-char Date: Thu, 10 Jan 2013 02:24:27 +0200 Organization: JURTA Message-ID: <87fw29vq9v.fsf@mail.jurta.org> References: <20121010.173658.77853335142870486.hanche@math.ntnu.no> <87d2xsxy9q.fsf@mail.jurta.org> <878v89u7pg.fsf@mail.jurta.org> <87pq1fjjfu.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1357778213 29128 80.91.229.3 (10 Jan 2013 00:36:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Jan 2013 00:36:53 +0000 (UTC) Cc: 12615@debbugs.gnu.org, Harald Hanche-Olsen To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 10 01:37:10 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tt68r-0007b2-QN for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Jan 2013 01:37:09 +0100 Original-Received: from localhost ([::1]:50561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt68b-0005yV-MM for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Jan 2013 19:36:53 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt68Z-0005yF-E0 for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 19:36:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tt68Y-00075N-1E for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 19:36:51 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tt68X-00075J-U2 for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 19:36:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tt68k-0000XE-1z for bug-gnu-emacs@gnu.org; Wed, 09 Jan 2013 19:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jan 2013 00:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12615-submit@debbugs.gnu.org id=B12615.13577781811995 (code B ref 12615); Thu, 10 Jan 2013 00:37:01 +0000 Original-Received: (at 12615) by debbugs.gnu.org; 10 Jan 2013 00:36:21 +0000 Original-Received: from localhost ([127.0.0.1]:59204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt683-0000W6-Su for submit@debbugs.gnu.org; Wed, 09 Jan 2013 19:36:21 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:55704 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tt680-0000Vs-Ps; Wed, 09 Jan 2013 19:36:18 -0500 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 2E6FA229B5BC41; Wed, 9 Jan 2013 16:36:01 -0800 (PST) In-Reply-To: <87pq1fjjfu.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 09 Jan 2013 02:20:29 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69551 Archived-At: reopen 12615 thanks >> I'd guess only completing-read would need to do it, rather than >> read_minibuf. > > Then `completing-read-default' would be a good place too > (anyone who overrides `completing-read-function' have to copy most of > code from `completing-read-default' anyway). I tried to do this in `completing-read-default', and it seems to fix the reported problem, and (make-local-variable 'completion-ignore-case) in the *scratch* buffer doesn't override the let-binding in `read-char-by-name': === modified file 'lisp/minibuffer.el' --- lisp/minibuffer.el 2013-01-03 00:36:36 +0000 +++ lisp/minibuffer.el 2013-01-10 00:23:05 +0000 @@ -3202,8 +3202,16 @@ (defun completing-read-default (prompt c ;; in minibuffer-local-filename-completion-map can ;; override bindings in base-keymap. base-keymap))) - (result (read-from-minibuffer prompt initial-input keymap - nil hist def inherit-input-method))) + ;; Get the value of `completion-ignore-case' from the original + ;; buffer where it is either buffer-local or let-bound. + (c-i-c completion-ignore-case) + (result + (minibuffer-with-setup-hook + (lambda () + ;; Copy the value from original buffer to the minibuffer. + (set (make-local-variable 'completion-ignore-case) c-i-c)) + (read-from-minibuffer prompt initial-input keymap + nil hist def inherit-input-method)))) (when (and (equal result "") def) (setq result (if (consp def) (car def) def))) result))