From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 12615@debbugs.gnu.org, Harald Hanche-Olsen <hanche@math.ntnu.no>
Subject: bug#12615: 24.2.50; Non-ignored case in insert-char
Date: Thu, 10 Jan 2013 02:24:27 +0200 [thread overview]
Message-ID: <87fw29vq9v.fsf@mail.jurta.org> (raw)
In-Reply-To: <87pq1fjjfu.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 09 Jan 2013 02:20:29 +0200")
reopen 12615
thanks
>> I'd guess only completing-read would need to do it, rather than
>> read_minibuf.
>
> Then `completing-read-default' would be a good place too
> (anyone who overrides `completing-read-function' have to copy most of
> code from `completing-read-default' anyway).
I tried to do this in `completing-read-default', and it seems to fix the
reported problem, and (make-local-variable 'completion-ignore-case) in
the *scratch* buffer doesn't override the let-binding in `read-char-by-name':
=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el 2013-01-03 00:36:36 +0000
+++ lisp/minibuffer.el 2013-01-10 00:23:05 +0000
@@ -3202,8 +3202,16 @@ (defun completing-read-default (prompt c
;; in minibuffer-local-filename-completion-map can
;; override bindings in base-keymap.
base-keymap)))
- (result (read-from-minibuffer prompt initial-input keymap
- nil hist def inherit-input-method)))
+ ;; Get the value of `completion-ignore-case' from the original
+ ;; buffer where it is either buffer-local or let-bound.
+ (c-i-c completion-ignore-case)
+ (result
+ (minibuffer-with-setup-hook
+ (lambda ()
+ ;; Copy the value from original buffer to the minibuffer.
+ (set (make-local-variable 'completion-ignore-case) c-i-c))
+ (read-from-minibuffer prompt initial-input keymap
+ nil hist def inherit-input-method))))
(when (and (equal result "") def)
(setq result (if (consp def) (car def) def)))
result))
next prev parent reply other threads:[~2013-01-10 0:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 15:36 bug#12615: 24.2.50; Non-ignored case in insert-char Harald Hanche-Olsen
2012-10-10 18:03 ` Harald Hanche-Olsen
2012-10-10 19:30 ` Andreas Schwab
2012-10-10 21:31 ` Glenn Morris
2012-10-11 6:32 ` Harald Hanche-Olsen
2012-10-11 0:56 ` Stefan Monnier
2012-10-11 6:37 ` Harald Hanche-Olsen
2012-10-11 20:12 ` Stefan Monnier
2012-12-29 22:56 ` Juri Linkov
2013-01-04 0:13 ` Juri Linkov
2013-01-08 0:45 ` Juri Linkov
2013-01-08 3:19 ` Stefan Monnier
2013-01-09 0:20 ` Juri Linkov
2013-01-09 2:41 ` Stefan Monnier
2013-01-10 0:24 ` Juri Linkov [this message]
2013-01-10 2:50 ` Stefan Monnier
2020-09-13 16:33 ` Lars Ingebrigtsen
2022-04-22 12:35 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw29vq9v.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=12615@debbugs.gnu.org \
--cc=hanche@math.ntnu.no \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.