all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleksandr Gavenko <gavenkoa@gmail.com>
To: help-gnu-emacs@gnu.org
Subject: Re: "defmacro" and "local variables" and "let" and "nconc" strange behaviour...
Date: Sun, 13 Jan 2013 16:18:46 +0200	[thread overview]
Message-ID: <87fw256u9l.fsf@gavenkoa.example.com> (raw)
In-Reply-To: 87k3rh6uez.fsf@gavenkoa.example.com

On 2013-01-13, Oleksandr Gavenko wrote:

> I wrote simple macro:
>
>   (defmacro my-filter (pred list)
>     "Construct list with elements from LIST which satisfy PRED."
>     (let ( (r (make-symbol "r_")) )
>       `(let ( (,r '(nil)) )
>          (mapc (lambda (item)
>                  (when (,pred item)
>                    (nconc ,r (cons item nil))))
>                ,list)
>          (cdr ,r))))
>
> When I evaluate several times:
>
>   (my-filter (lambda (x) x) '(1 nil "a"))
>
> I get sequentially:
>
>   (1 "a")
>   (1 "a" 1 "a")
>   (1 "a" 1 "a" 1 "a")
>   (1 "a" 1 "a" 1 "a" 1 "a")
>
> When I eval:
>
>   (pp (macroexpand '(my-filter (lambda (x) x) '(1 nil "a"))))
>
> I get:
>
>   (let
>       ((r_
>         '(nil 1 "a" 1 "a" 1 "a" 1 "a" 1 "a" 1 "a" 1 "a" 1 "a")))
>     (mapc
>      (lambda
>        (item)
>        (when
>            ((lambda
>               (x)
>               x)
>             item)
>          (nconc r_
>                 (cons item nil))))
>      '(1 nil "a"))
>     (cdr r_))
>
> Why instead of '(nil) I get something else?

I found fix by changing '(nil) to (list nil). Please explain why first variant
fail?

-- 
Best regards!




  reply	other threads:[~2013-01-13 14:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 14:15 "defmacro" and "local variables" and "let" and "nconc" strange behaviour Oleksandr Gavenko
2013-01-13 14:18 ` Oleksandr Gavenko [this message]
     [not found] ` <mailman.17291.1358086805.855.help-gnu-emacs@gnu.org>
2013-01-14  9:04   ` jack-mac
     [not found] <mailman.17290.1358086558.855.help-gnu-emacs@gnu.org>
2013-01-13 14:21 ` Barry Margolin
2013-01-13 15:00   ` Oleksandr Gavenko
2013-01-13 16:45     ` Le Wang
2013-01-13 17:25       ` Oleksandr Gavenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw256u9l.fsf@gavenkoa.example.com \
    --to=gavenkoa@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.