From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#13321: 24.3.0.50; Gmail error when replying from Gnus to github Date: Thu, 21 Feb 2013 20:40:32 +0100 Organization: Emacs Helm Message-ID: <87fw0pihfz.fsf@gmail.com> References: <87a9surugk.fsf@gmail.com> <87zk0rffsg.fsf@gmail.com> <87mwwqg78u.fsf@gmail.com> <87ip7eg43v.fsf@gmail.com> <87y5g4gp2c.fsf@gmail.com> <87txp5ocvp.fsf@gmail.com> <877gm1r4lv.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1361475714 4071 80.91.229.3 (21 Feb 2013 19:41:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Feb 2013 19:41:54 +0000 (UTC) To: 13321@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 21 20:42:16 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U8c1x-00038I-6J for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Feb 2013 20:42:09 +0100 Original-Received: from localhost ([::1]:59370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8c1c-0003XC-QX for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Feb 2013 14:41:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8c1Z-0003Wt-T6 for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 14:41:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8c1Y-00053Q-Jv for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 14:41:45 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8c1Y-00053K-Gl for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 14:41:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U8c2n-0001w2-Ut; Thu, 21 Feb 2013 14:43:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87a9surugk.fsf@gmail.com> Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 21 Feb 2013 19:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13321 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13614757307378 (code B ref -1); Thu, 21 Feb 2013 19:43:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Feb 2013 19:42:10 +0000 Original-Received: from localhost ([127.0.0.1]:42904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8c1y-0001ux-8O for submit@debbugs.gnu.org; Thu, 21 Feb 2013 14:42:10 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41152) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8c1w-0001uq-If for submit@debbugs.gnu.org; Thu, 21 Feb 2013 14:42:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8c0e-0004e9-Bj for submit@debbugs.gnu.org; Thu, 21 Feb 2013 14:40:50 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:40588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8c0e-0004di-2t for submit@debbugs.gnu.org; Thu, 21 Feb 2013 14:40:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8c0b-0003QV-O2 for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 14:40:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8c0a-0004bm-D6 for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 14:40:45 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:56383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8c0a-0004bI-43 for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 14:40:44 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1U8c0s-0002L4-0I for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 20:41:02 +0100 Original-Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 21 Feb 2013 20:41:01 +0100 Original-Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 21 Feb 2013 20:41:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 59 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:/d20lTJlPoQp3in9+VNpSLYiZa8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71610 Archived-At: Thierry Volpiatto writes: > Hi Lars, > > Thierry Volpiatto writes: > >> Hi Lars, >> >> Thierry Volpiatto writes: >> >> I have isolated the problem to message.el, so when I load the message.el >> of emacs-24 branch the problem disapear. >> I will try to (re)diff the file to found out what is wrong there. >> Perhaps you can have a look on your side too ? > > So the problem comes from `message-get-reply-headers', more exactly this > piece of code: > > ;; Make sure this message goes to the author if this is a wide > ;; reply, since Reply-To address may be a list address a mailing > ;; list server added. > (when (and wide author) > (setq cc (concat author ", " cc))) > (when (or wide (not author)) > (setq author (or (message-fetch-field "from") "")))) > > In our case the "from" field contain "notification@github.com" which is > the place where we should never reply. Here the commit that introduce this bug: --8<---------------cut here---------------start------------->8--- 2559724 * | Author: Katsumi Yamaoka | Date: Mon Nov 19 06:24:03 2012 +0000 | | message.el (message-get-reply-headers): Make sure the reply goes to the author if it is a wide reply | | lisp/ChangeLog | 5 +++++ | lisp/message.el | 13 +++++++++---- | 2 files changed, 14 insertions(+), 4 deletions(-) --8<---------------cut here---------------end--------------->8--- With this change, here what is happening, sending a reply in same topic on github: ;; BAD emacs-24.3.50 ;; To: Le Wang ;; Cc: emacs-helm/helm , emacs-helm/helm ;; GOOD emacs-24.2.93 ;; To: emacs-helm/helm ;; Cc: emacs-helm/helm -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997