From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Schulte Newsgroups: gmane.emacs.bugs Subject: bug#14089: 24.3; file local variables can't have a colon in their name Date: Wed, 03 Apr 2013 08:31:13 -0600 Message-ID: <87fvz7wsos.fsf@gmail.com> References: <877gkqqbc6.fsf@gmail.com> <87ppybhkvj.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365002369 16738 80.91.229.3 (3 Apr 2013 15:19:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Apr 2013 15:19:29 +0000 (UTC) Cc: 14089@debbugs.gnu.org To: Bastien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 03 17:19:56 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UNPTd-00084j-Rb for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2013 17:19:53 +0200 Original-Received: from localhost ([::1]:35923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNPTF-0006sg-1k for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2013 11:19:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNPQt-0003Jz-03 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2013 11:17:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNPQo-00080Z-7K for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2013 11:17:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNPQo-00080V-2f for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2013 11:16:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UNPTl-0002xa-W0 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2013 11:20:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <877gkqqbc6.fsf@gmail.com> Resent-From: Eric Schulte Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Apr 2013 15:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14089 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14089-submit@debbugs.gnu.org id=B14089.136500239211359 (code B ref 14089); Wed, 03 Apr 2013 15:20:01 +0000 Original-Received: (at 14089) by debbugs.gnu.org; 3 Apr 2013 15:19:52 +0000 Original-Received: from localhost ([127.0.0.1]:60191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UNPTY-0002x0-Gs for submit@debbugs.gnu.org; Wed, 03 Apr 2013 11:19:51 -0400 Original-Received: from mail-pa0-f54.google.com ([209.85.220.54]:55002) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UNPTU-0002wr-Qq for 14089@debbugs.gnu.org; Wed, 03 Apr 2013 11:19:46 -0400 Original-Received: by mail-pa0-f54.google.com with SMTP id fa11so943376pad.27 for <14089@debbugs.gnu.org>; Wed, 03 Apr 2013 08:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:references:message-id:user-agent :mime-version:content-type; bh=kPrAZ8Ro5Ra5g8u2xaMIOmERkfmXZYG7moyP4dCJUlk=; b=tIP3eP4bPsl3imkMqrVg38grtJ7UXCzLqTHDTiN6ETVWWi3NyjKjcDqge0/b1Xz8tH ULNRMxSLRH4q1lipIAreoO5N9fdXsS1/FgZUFNQZH4TfWbegV+0J4Ysm7c4KH24BUOUr sjQZ3txM8X5xoFiWnxPRdfB3STxBNjTt6IFB2vKm3MOlevASa/iQ/oi04CX4XI77I5+O x8KGHMWRUQt9H99orJFhDjO8oLRmdlt2vz1lLjsf+C/7Gnr7MP/HnnxHyo3mUF42fiL4 nfB+vjbAfRssIslS7IWit+v8Dlm+5eGSx3Q3/JWzYw9UU4NTBlQRBldmIo90tENO55Vd a9gQ== X-Received: by 10.68.197.4 with SMTP id iq4mr3102899pbc.96.1365002199606; Wed, 03 Apr 2013 08:16:39 -0700 (PDT) Original-Received: from bagel (adaptive.cs.unm.edu. [64.106.46.2]) by mx.google.com with ESMTPS id gf1sm6343587pbb.33.2013.04.03.08.16.38 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 03 Apr 2013 08:16:38 -0700 (PDT) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73109 Archived-At: Bastien writes: > Hi Eric, > > here is an updated patch for handling this. > > The idea is to allow ":" in mode's names and variables names. > No need to use two `looking-at' in this case I think. > > I'll submit the patch to emacs-devel and apply it if it's good. > Fantastic, Thanks. > > Thanks, > > schulte.eric@gmail.com writes: > >> === modified file 'lisp/files.el' >> --- lisp/files.el 2013-03-24 06:42:25 +0000 >> +++ lisp/files.el 2013-03-28 23:09:26 +0000 >> @@ -3058,7 +3058,11 @@ >> (while (and (or (not mode-only) >> (not result)) >> (< (point) end)) >> - (unless (looking-at "[ \t]*\\([^ \t\n:]+\\)[ \t]*:[ \t]*") >> + ;; The first of these next two regexs handles the >> + ;; case when a variable name includes a ":", such as >> + ;; the `org-babel-default-header-args:R' variable. >> + (unless (or (looking-at "[ \t]*\\([^ \t\n]?+\\)[ \t]*:[ \t]*") >> + (looking-at "[ \t]*\\([^ \t\n:]+\\)[ \t]*:[ \t]*")) >> (message "Malformed mode-line") >> (throw 'malformed-line nil)) >> (goto-char (match-end 0)) -- Eric Schulte http://cs.unm.edu/~eschulte