From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [PATCH 04/10] Add 'light argument to some uses of org-babel-get-src-block-info Date: Thu, 18 Apr 2013 03:09:00 -0400 Message-ID: <87fvyos4c3.fsf@gmail.com> References: <1364794944-13826-1-git-send-email-aaronecay@gmail.com> <1364794944-13826-5-git-send-email-aaronecay@gmail.com> <8738v7y79j.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:51632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USixs-0004Qe-0f for emacs-orgmode@gnu.org; Thu, 18 Apr 2013 03:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USixq-0002IA-Jm for emacs-orgmode@gnu.org; Thu, 18 Apr 2013 03:09:03 -0400 Received: from mail-vb0-x232.google.com ([2607:f8b0:400c:c02::232]:35677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USixq-0002I6-FV for emacs-orgmode@gnu.org; Thu, 18 Apr 2013 03:09:02 -0400 Received: by mail-vb0-f50.google.com with SMTP id w15so2003949vbb.37 for ; Thu, 18 Apr 2013 00:09:02 -0700 (PDT) In-Reply-To: <8738v7y79j.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: emacs-orgmode@gnu.org Hi Eric, 2013ko apirilak 3an, Eric Schulte-ek idatzi zuen: > > Aaron Ecay writes: > >> * lisp/ob-core.el (org-babel-do-key-sequence-in-edit-buffer), >> (org-babel-expand-noweb-references), >> * lisp/ob-tangle.el (org-babel-tangle): >> Use 'light argument to `org-babel-get-src-block-info'. > > I'd like to apply this patch, however tracing the effects of these > changes can be tricky and `org-babel-expand-noweb-references' and > `org-babel-tangle' are both core functions. > > Have you run the test suite to confirm that these changes don't break > any existing tests? The test suite gives no failures with this patch. -- Aaron Ecay