From: Matt Lundin <mdl@imapmail.org>
To: Nick Dokos <ndokos@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Infinite loop in org-agenda-show-new-time
Date: Wed, 14 Aug 2013 10:15:37 -0500 [thread overview]
Message-ID: <87fvucuwva.fsf@fastmail.fm> (raw)
In-Reply-To: <87mwopinzv.fsf@gmail.com> (Nick Dokos's message of "Sat, 10 Aug 2013 11:06:44 -0400")
Nick Dokos <ndokos@gmail.com> writes:
> Matt Lundin <mdl@imapmail.org> writes:
>
>> ...
>> In other words, within the agenda buffer, move-to-column and
>> move-end-of-line will move to the point to the end of the entire
>> invisible region. That is why removing the local binding of
>> buffer-invisibility-spec to nil triggers this bug, because when that
>> variable is nil, the function org-agenda-show-new-time temporarily
>> treats the agenda buffer as if it were visible (i.e., it ignores the
>> invisible overlay).
>>
>
> I haven't been able to work on the problem, but assuming that your
> diagnosis above is correct, perhaps the thing to do is to bind
> buffeer-invisibility-spec to nil inside org-move-to-column:
>
> (defun org-move-to-column (column &optional force buffer)
> (let ((buffer-invisibility-spec nil))
> (if (featurep 'xemacs)
> (org-xemacs-without-invisibility (move-to-column column force buffer))
> (move-to-column column force))))
>
> What do you think?
That solves the problem beautifully. Would it have any negative
side-effects for other org functions, especially those that invoke
org-move-to-column in normal org buffers?
Here's a list of such invocations:
--8<---------------cut here---------------start------------->8---
-*- mode: grep; default-directory: "~/org-mode/lisp/" -*-
Grep started at Wed Aug 14 10:14:17
grep -nH -e org-move-to-column *.el
org-agenda.el:8248: (org-move-to-column col))
org-agenda.el:8260: (org-move-to-column col)))
org-agenda.el:8766: (org-move-to-column col))))
org-agenda.el:9130: (org-move-to-column (- (window-width) (length stamp)) t)
org-agenda.el:9232: (org-move-to-column col))))
org-agenda.el:9252: (org-move-to-column col)
org-clock.el:1851: (org-move-to-column c)
org-colview.el:503: (org-move-to-column col)
org-colview.el:632: (org-move-to-column col)
org-compat.el:338:(defun org-move-to-column (column &optional force buffer)
org.el:9440: (if (< (current-column) gc) (org-move-to-column gc t) (insert " "))
org.el:14377: (org-move-to-column (min ncol col) t))
org.el:14532: (org-move-to-column col)
org.el:14616: (org-move-to-column (- (window-width) 19) t)
org.el:22037: (org-move-to-column column))))
org.el:22465: (org-move-to-column min-indent t))
org.el:22588: (org-move-to-column cc t)
org.el:22593: ((not off) (org-move-to-column cc t) (insert ": ")))
org.el:23360: (org-move-to-column c))))
org-list.el:2170: (org-move-to-column col)))
org-list.el:2189: (org-move-to-column col)))
org-macs.el:110: (org-move-to-column ,col)))))
org-src.el:358: (org-move-to-column
org-src.el:364: (org-move-to-column
org-src.el:537: (org-move-to-column (max 0 (- col block-nindent 2)))
org-src.el:771: (org-move-to-column (if preserve-indentation col (+ col total-nindent delta)))))
org-table.el:1121: (org-move-to-column col)
org-table.el:1126: (org-move-to-column col))
org-table.el:1353: (org-move-to-column col)
org-table.el:1358: (org-move-to-column col))
org-table.el:1507: (org-move-to-column col)
org-table.el:1559: (org-move-to-column col)
org-table.el:1599: (org-move-to-column col)
Grep finished (matches found) at Wed Aug 14 10:14:17
--8<---------------cut here---------------end--------------->8---
Matt
next prev parent reply other threads:[~2013-08-14 15:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 15:42 [BUG] Infinite loop in org-agenda-show-new-time Matt Lundin
2013-08-05 17:13 ` Nick Dokos
2013-08-05 20:14 ` Matt Lundin
2013-08-05 22:05 ` Nick Dokos
2013-08-06 17:36 ` Matt Lundin
2013-08-06 21:35 ` Nick Dokos
2013-08-06 22:45 ` Nick Dokos
2013-08-14 15:19 ` Matt Lundin
2013-08-14 15:38 ` Nick Dokos
2013-08-10 15:06 ` Nick Dokos
2013-08-14 15:15 ` Matt Lundin [this message]
2013-08-14 15:45 ` Nick Dokos
2013-08-23 9:58 ` Carsten Dominik
2013-08-23 12:07 ` Nick Dokos
2019-12-26 19:37 ` Andrew Hyatt
2020-02-01 9:32 ` Bastien
2020-02-02 15:19 ` Andrew Hyatt
2020-02-03 19:04 ` Bastien
2020-02-04 19:25 ` Andrew Hyatt
2020-02-04 23:38 ` Bastien
2020-02-05 16:34 ` Andrew Hyatt
2020-02-05 19:50 ` Matthew Lundin
2020-02-11 7:56 ` Bastien
2020-02-14 3:27 ` Andrew Hyatt
2020-02-14 10:02 ` Bastien
2020-02-17 19:20 ` Andrew Hyatt
2020-02-17 22:53 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvucuwva.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=emacs-orgmode@gnu.org \
--cc=ndokos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.