From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#15200: isearch-other-meta-char and shift Date: Tue, 27 Aug 2013 19:45:51 +0300 Organization: JURTA Message-ID: <87fvtvgk00.fsf@mail.jurta.org> References: <8761urkssh.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1377622162 18706 80.91.229.3 (27 Aug 2013 16:49:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Aug 2013 16:49:22 +0000 (UTC) To: 15200@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 27 18:49:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VEMSE-0003CH-1k for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2013 18:49:18 +0200 Original-Received: from localhost ([::1]:57527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEMSD-0003oF-Nj for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2013 12:49:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEMS4-0003eP-Nd for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2013 12:49:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEMRy-0003lL-O3 for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2013 12:49:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEMRy-0003lH-Km for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2013 12:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VEMRy-00030Z-4t for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2013 12:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2013 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15200 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15200-submit@debbugs.gnu.org id=B15200.137762213611550 (code B ref 15200); Tue, 27 Aug 2013 16:49:01 +0000 Original-Received: (at 15200) by debbugs.gnu.org; 27 Aug 2013 16:48:56 +0000 Original-Received: from localhost ([127.0.0.1]:59511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VEMRs-00030D-12 for submit@debbugs.gnu.org; Tue, 27 Aug 2013 12:48:56 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:52202 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VEMRp-000304-6j for 15200@debbugs.gnu.org; Tue, 27 Aug 2013 12:48:53 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 77A95258B9E935 for <15200@debbugs.gnu.org>; Tue, 27 Aug 2013 09:48:51 -0700 (PDT) In-Reply-To: <8761urkssh.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 27 Aug 2013 19:28:22 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77773 Archived-At: Another problem is that shifted cursor motion keys don't activate the region. Test case: `C-s S-right' exits isearch (OK), moves cursor to the right (OK), but doesn't activate the region (BUG). The same bug is for other shift-selection keys: `C-s S-C-right', `C-s S-C-f', `C-s S-M-f' don't activate the region like they do outside of isearch. I see that the shift key is swallowed by `read-key-sequence' in `isearch-reread-key-sequence-naturally' called from `isearch-other-meta-char'. However, when the argument DONT-DOWNCASE-LAST of `read-key-sequence' is non-nil, it doesn't translate shifted keys and leaves shift-modifiers with them in `unread-command-events': === modified file 'lisp/isearch.el' --- lisp/isearch.el 2013-07-05 20:15:32 +0000 +++ lisp/isearch.el 2013-08-27 16:38:41 +0000 @@ -2502,7 +2556,9 @@ (defun isearch-reread-key-sequence-natur Return the key sequence as a string/vector." (isearch-unread-key-sequence keylist) (let (overriding-terminal-local-map) - (read-key-sequence nil))) ; This will go through function-key-map, if nec. + ;; This will go through function-key-map, if nec. + ;; The arg DONT-DOWNCASE-LAST prevents premature shift-translation. + (read-key-sequence nil nil t))) (defalias 'isearch-other-control-char 'isearch-other-meta-char)