From: fabian@anue.biz
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Daniel Elliott" <danelliottster@gmail.com>,
"Fabián E. Gallina" <fabian@gnu.org>,
15137@debbugs.gnu.org
Subject: bug#15137: python mode patch
Date: Sat, 31 Aug 2013 09:44:43 -0300 [thread overview]
Message-ID: <87fvtqf2ro.fsf@anue.biz> (raw)
In-Reply-To: <jwvioyr6gts.fsf-monnier+emacs@gnu.org>
monnier@iro.umontreal.ca writes:
>> ! (buffer-substring start end))
> [...]
>> ! ;; wrap with a conditional to avoid errors about python unexpected indentation
>> ! "if True:\n"
>> ! (buffer-substring start end)
>> ! "\n")
>
> That looks pretty good, thank you.
> Fabián, could you take a look?
>
The idea is good but the patch needs bit more of work -- this approach
will work when an indented region is sent but won't when sending a
region which starts with no indentation at all. Also backtraces numbers
will be wrong for a -1 offset.
I'll push something for this soon.
Regards,
Fabián.
next prev parent reply other threads:[~2013-08-31 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 21:25 bug#15137: python mode patch Daniel Elliott
2013-08-27 1:54 ` Stefan Monnier
2013-08-31 12:44 ` fabian [this message]
2013-09-01 7:25 ` Andreas Röhler
2013-09-09 14:15 ` Daniel Elliott
2013-09-02 14:16 ` fgallina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvtqf2ro.fsf@anue.biz \
--to=fabian@anue.biz \
--cc=15137@debbugs.gnu.org \
--cc=danelliottster@gmail.com \
--cc=fabian@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.