* msys-to-w32 (was: Building Emacs from a new MinGW environment)
@ 2013-11-12 8:08 Dani Moncayo
2013-11-12 18:42 ` msys-to-w32 Sean Sieger
2013-11-18 7:38 ` msys-to-w32 (was: Building Emacs from a new MinGW environment) Dani Moncayo
0 siblings, 2 replies; 3+ messages in thread
From: Dani Moncayo @ 2013-11-12 8:08 UTC (permalink / raw)
To: Glenn Morris; +Cc: Emacs development discussions
Thanks for the code review, Glenn.
I agree with your comments. See below the changes I've made.
This is the new version of the whole patch, against trunk revno 115072:
https://www.dropbox.com/s/lqgogbn6mrb2qs0/msys-to-w32.v4.diff
diff --git a/build-aux/msys-to-w32 b/build-aux/msys-to-w32
index d4b0c7b..5750831 100644
--- a/build-aux/msys-to-w32
+++ b/build-aux/msys-to-w32
@@ -3,12 +3,6 @@
# MS-Windows format.
# Status is zero if successful, nonzero otherwise.
-VERSION='2013-11-11 19:18'; # UTC
-# The definition above must lie within the first 8 lines in order
-# for the Emacs time-stamp write hook (at end) to update it.
-# If you change this file with Emacs, please let the write hook
-# do its job. Otherwise, update this string manually.
-
# Copyright (C) 2013 Free Software Foundation, Inc.
# This program is free software: you can redistribute it and/or modify
@@ -58,24 +52,14 @@ SEPARATOR.
Options:
--help display this help and exit
- --version output version information and exit
Report bugs to <bug-gnu-emacs@gnu.org>."
-version=`expr "$VERSION" : '\([^ ]*\)'`
-version="msys-to-w32 $version
-Copyright (C) 2011 Free Software Foundation, Inc.
-License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
-This is free software: you are free to change and redistribute it.
-There is NO WARRANTY, to the extent permitted by law."
-
for arg
do
case $arg in
--help | --hel | --he | --h)
exec echo "$help" ;;
- --version | --versio | --versi | --vers | --ver | --ve | --v)
- exec echo "$version" ;;
--)
shift
break ;;
@@ -179,11 +163,3 @@ done
# Write the translated pathlist to the standard output
printf "${pathlist2}"
-
-## Local Variables:
-## eval: (add-hook 'write-file-functions 'time-stamp)
-## time-stamp-start: "VERSION='"
-## time-stamp-format: "%:y-%02m-%02d %02H:%02M"
-## time-stamp-time-zone: "UTC"
-## time-stamp-end: "'; # UTC"
-## End:
--
Dani Moncayo
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: msys-to-w32
2013-11-12 8:08 msys-to-w32 (was: Building Emacs from a new MinGW environment) Dani Moncayo
@ 2013-11-12 18:42 ` Sean Sieger
2013-11-18 7:38 ` msys-to-w32 (was: Building Emacs from a new MinGW environment) Dani Moncayo
1 sibling, 0 replies; 3+ messages in thread
From: Sean Sieger @ 2013-11-12 18:42 UTC (permalink / raw)
To: emacs-devel
Dani, Glenn, thank you for your work on this, it seems to work fine.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: msys-to-w32 (was: Building Emacs from a new MinGW environment)
2013-11-12 8:08 msys-to-w32 (was: Building Emacs from a new MinGW environment) Dani Moncayo
2013-11-12 18:42 ` msys-to-w32 Sean Sieger
@ 2013-11-18 7:38 ` Dani Moncayo
1 sibling, 0 replies; 3+ messages in thread
From: Dani Moncayo @ 2013-11-18 7:38 UTC (permalink / raw)
To: Emacs development discussions
On Tue, Nov 12, 2013 at 9:08 AM, Dani Moncayo <dmoncayo@gmail.com> wrote:
> Thanks for the code review, Glenn.
>
> I agree with your comments. See below the changes I've made.
>
> This is the new version of the whole patch, against trunk revno 115072:
>
> https://www.dropbox.com/s/lqgogbn6mrb2qs0/msys-to-w32.v4.diff
There were no more comments about the above patch.
How about committing it, please?
--
Dani Moncayo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-18 7:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-12 8:08 msys-to-w32 (was: Building Emacs from a new MinGW environment) Dani Moncayo
2013-11-12 18:42 ` msys-to-w32 Sean Sieger
2013-11-18 7:38 ` msys-to-w32 (was: Building Emacs from a new MinGW environment) Dani Moncayo
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.