From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Politz Newsgroups: gmane.emacs.bugs Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Date: Tue, 10 Dec 2013 11:02:41 +0100 Message-ID: <87fvq1t45a.fsf@hochschule-trier.de> References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386670876 8053 80.91.229.3 (10 Dec 2013 10:21:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Dec 2013 10:21:16 +0000 (UTC) Cc: 16090@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 10 11:21:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VqKRN-0001oU-1i for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2013 11:21:21 +0100 Original-Received: from localhost ([::1]:48287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqKRM-0003Na-E1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2013 05:21:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqKR9-0003AD-GQ for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 05:21:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqKR4-00006T-5c for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 05:21:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqKR4-00006P-2S for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 05:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VqKR3-0001tH-Sf for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 05:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Politz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2013 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16090-submit@debbugs.gnu.org id=B16090.13866708377231 (code B ref 16090); Tue, 10 Dec 2013 10:21:01 +0000 Original-Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 10:20:37 +0000 Original-Received: from localhost ([127.0.0.1]:41441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqKQe-0001sY-V7 for submit@debbugs.gnu.org; Tue, 10 Dec 2013 05:20:37 -0500 Original-Received: from gateway-a.fh-trier.de ([143.93.54.181]:54010) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqKQc-0001sK-67 for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 05:20:36 -0500 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier] Original-Received: from luca (dslb-178-004-212-017.pools.arcor-ip.net [178.4.212.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 4F0601788BF1; Tue, 10 Dec 2013 11:02:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1386669762; bh=kQDy8mEtREIQxDdOlJsjXuxGAEo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=Ae16VtjesMbkV9E1+tVnWo3EAu1k68kTCzqlkIsM8OmIkdvA3TnnyPUu49jjRBjKq BiSlj47nu1vL+vpCkfJqpzNihbXTU1+w0Zb+Q5BewUa7u8nUJ3B3ZTA7dRP+hs20+p oOLoBgqrTsFRGFNHiyOmKAPz+fYKDzTSMWq/hfp4= Original-Received: from politza by luca with local (Exim 4.72) (envelope-from ) id 1VqK9J-0002V1-I7; Tue, 10 Dec 2013 11:02:41 +0100 In-Reply-To: <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> (Tassilo Horn's message of "Tue, 10 Dec 2013 08:53:38 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81666 Archived-At: Tassilo Horn writes: > Stefan Monnier writes: >> The code is already equipped to handle non-displayed buffers (it >> keeps track of the "default current page" which is later used when/if >> the buffer gets displayed in a window). I see. So the problem is the (with-selected-window (or ... (selected-window))), which most of the times makes the wrong buffer current (having image-mode-winprops-alist eq t). > > Yes, but I think that doesn't suffice. The problem with bookmarks is > that the display window function is run after the bookmark handler, so > we have no clue in which window the bookmarked page is going to be > shown. [...] What about setting an additional property for the page in image-mode-winprops-alist and removing it later in doc-view-new-window-function ? -ap