From: Bastien <bzg@altern.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 15980@debbugs.gnu.org
Subject: bug#15980: 24.3.50; `minibuffer-complete-word': case where it does not work correctly
Date: Tue, 07 Jan 2014 18:14:06 +0100 [thread overview]
Message-ID: <87fvozg1ep.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87d76d4c-4684-43de-876e-46ebbdcb4b3e@default> (Drew Adams's message of "Tue, 7 Jan 2014 09:06:36 -0800 (PST)")
Drew Adams <drew.adams@oracle.com> writes:
>> > Since SPC is supposed to complete a word at a time, and since both
>> > ` ' and `-' are word separators, I would expect that there are two
>> > word completions for the prefix `cmd': `cmd ' and `cmd-'.
>> >
>> > So I would expect to see *Completions* displayed, showing the two
>> > candidates `cmd w ith spaces' and `cmd-without-spaces'.
>>
>> See the first comment in `completion--try-word-completion':
>> the function considers that either a space *or* an hyphen will
>> be used to separate words. The "or" is exclusive.
>
> `completion--try-word-completion' is an *implementation*. If that's
> what it does then it does not do what the doc says, right? So either
> the doc needs to be fixed to fit the implementation or vice versa, no?
`completion--try-word-completion' does not have a docstring.
>> > Admittedly, this is a corner use case.
>
> I meant corner case for command names. It is not a corner case
> to have space chars in completion candidates.
Agreed.
>> Yes -- note that TAB works fine here instead of SPC.
>>
>> The only place I can think of where this could be a problem
>> is the info manual (`g' or `i' to go to a node or to find an
>> index entry.)
>
> Why is that the only place you can think of?
Because my thinking is limited.
> Are you saying that
> because those completion candidates contain space chars? There
> are *lot* of places where Emacs can use completion for candidates
> that contain space chars.
My point is that there is little chance that *many* non-contrived
strings can be completed either as xxx- or as xxx\ (wich a space.)
> `completing-read' is completely
> general. Emacs should make no assumptions about whether completion
> candidates happen to contain spaces.
Agreed. I couldn't find a fix.
>> Still, you're not like to stumble on such case.
>
> What makes you say that?
Instinct. But I can be proven wrong, of course.
>> I'm for closing this bug until it really hit someone.
>
> That's not right. The product and the doc do not agree, as you
> have pointed out. That alone is a bug. One way or another it
> should be fixed.
So let's keep this open and find someone that can fix it properly.
--
Bastien
next prev parent reply other threads:[~2014-01-07 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 17:11 bug#15980: 24.3.50; `minibuffer-complete-word': case where it does not work correctly Drew Adams
2014-01-07 12:04 ` Bastien Guerry
2014-01-07 17:06 ` Drew Adams
2014-01-07 17:14 ` Bastien [this message]
2014-01-07 17:50 ` Drew Adams
2014-01-07 23:37 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvozg1ep.fsf@bzg.ath.cx \
--to=bzg@altern.org \
--cc=15980@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.