bug#13826: Bug#701711: emacs24: svn support fails in a symlinked directory

bug#13826: Bug#701711: emacs24: svn support fails in a symlinked directory

[Rob Browning]

(If possible, please preserve the 701711-forwarded address in any replies.)

Juha Jäykkä <juhaj@iki.fi> writes:

> Version: 24.2+1-2

> vc-update and other vc-*-commands fail to detect an svn controlled
> directory when the directory is a symlink to an svn controlled
> directory.
>
> The new SVN working copy directory tree only has .svn directory at
> the topmost level and it seems emacs does 'chdir("..")' or something
> equivalent when it tries to find the .svn directory. However, if 
> directory A is a symlink to an svn working copy directory B, then
> looking at A/.. is not the right place to look for .svn; instead,
> emacs should note that A is a symlink, readlink() and look at B/..
> instead.

Further details can be found here:

   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701711

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

bug#13826: Bug#701711: emacs24: svn support fails in a symlinked directory

[Glenn Morris]

>> vc-update and other vc-*-commands fail to detect an svn controlled
>> directory when the directory is a symlink to an svn controlled
>> directory.

Works fine for me. Please give a complete recipe starting from emacs -Q.

Here's mine, using svn 1.7.8. I assume you are talking about
subdirectories, otherwise it makes no sense.

cd /tmp
svnadmin create repo
mkdir -p proj/sub/dir
cd proj
touch 1 sub/2 sub/dir/3
svn import . file:///tmp/repo/proj/trunk -m 'import'
cd ../
rm -rf proj
svn checkout file:///tmp/repo/proj/trunk proj
svn checkout file:///tmp/repo/proj/trunk proj2
cd proj2
echo foo >> sub/dir/3
svn commit -m "change" sub/dir/3
cd ../

ln -s proj/sub/dir

emacs-24.2 -Q dir/3 &    # visit file via linked directory

"Followed link to /tmp/proj/sub/dir/3" appears in echo-area.
SVN-1 appears in mode-line.

M-x vc-update

-> file is updated with "foo"

bug#13826: Bug#701711: emacs24: svn support fails in a symlinked directory

[Juha Jäykkä]

> >> vc-update and other vc-*-commands fail to detect an svn controlled
> >> directory when the directory is a symlink to an svn controlled
> >> directory.
> 
> Works fine for me. Please give a complete recipe starting from emacs -Q.

I'm sorry for the false alarm. I still think there is a bug, but not the one I 
reported.

This works

emacs -Q /path/to/symlink-directory/file

where /path/to/symlink-directory points to an SVN controlled directory.

However, if the variable vc-cvs-stay-local is set to nil in .emacs, then the 
emacs fails to notice that symlink-directory is SVN controlled.

Now, this may or may not be intended, but I believe it is a bug nevertheless. 
If it is not intended, there's the bug. If it is intended, then the 
documentation for vc-cvs-stay-local (not to mention the name of the variable 
implying that it affects CVS repositories only, but the documentation makes it 
clear this is not the case) is wrong:

   Non-nil means use local operations when possible for remote repositories.
   This avoids slow queries over the network and instead uses heuristics
   and past information to determine the current status of a file.
   
   If value is the symbol `only-file' `vc-dir' will connect to the
   server, but heuristics will be used to determine the status for
   all other VC operations.
   
   The value can also be a regular expression or list of regular
   expressions to match against the host name of a repository; then VC
   only stays local for hosts that match it.  Alternatively, the value
   can be a list of regular expressions where the first element is the
   symbol `except'; then VC always stays local except for hosts matched
   by these regular expressions.


Cheers,
Juha

-- 
		 -----------------------------------------------
		| Juha Jäykkä, juhaj@iki.fi			|
		| http://koti.kapsi.fi/~juhaj/			|
		 -----------------------------------------------

bug#13826: emacs24: svn support fails in a symlinked directory

[Glenn Morris]

Juha Jäykkä wrote:

> However, if the variable vc-cvs-stay-local is set to nil in .emacs, then the 
> emacs fails to notice that symlink-directory is SVN controlled.

It makes no difference for me whether I set vc-cvs-stay-local,
vc-svn-stay-local, or vc-stay-local to nil or t. The recipe I posted
still works fine. Do you have a recipe starting from emacs -Q that shows
the problem?

bug#13826: emacs24: svn support fails in a symlinked directory

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> Juha Jäykkä wrote:
>
>> However, if the variable vc-cvs-stay-local is set to nil in .emacs, then the 
>> emacs fails to notice that symlink-directory is SVN controlled.
>
> It makes no difference for me whether I set vc-cvs-stay-local,
> vc-svn-stay-local, or vc-stay-local to nil or t. The recipe I posted
> still works fine. Do you have a recipe starting from emacs -Q that shows
> the problem?

More information was requested almost a year ago, but no further
progress seems to have been made.  I'm closing this bug report now, but
if this problem still persists, please reopen it.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/