From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thorsten Jolitz Newsgroups: gmane.emacs.help Subject: Re: How to avoid y-or-n-p in a program? Date: Fri, 14 Mar 2014 15:48:03 +0100 Message-ID: <87fvmkq1jw.fsf@gmail.com> References: <87y50fqvh2.fsf@gmail.com> <87mwgsq2jg.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394808448 20643 80.91.229.3 (14 Mar 2014 14:47:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 14 Mar 2014 14:47:28 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Mar 14 15:47:36 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WOTOW-0005xu-AW for geh-help-gnu-emacs@m.gmane.org; Fri, 14 Mar 2014 15:47:32 +0100 Original-Received: from localhost ([::1]:45124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOTOV-0002eS-Po for geh-help-gnu-emacs@m.gmane.org; Fri, 14 Mar 2014 10:47:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOTOD-0002e0-Pg for help-gnu-emacs@gnu.org; Fri, 14 Mar 2014 10:47:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOTO6-0001RY-BQ for help-gnu-emacs@gnu.org; Fri, 14 Mar 2014 10:47:13 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:58836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOTO6-0001RM-49 for help-gnu-emacs@gnu.org; Fri, 14 Mar 2014 10:47:06 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WOTO4-0005bb-H0 for help-gnu-emacs@gnu.org; Fri, 14 Mar 2014 15:47:04 +0100 Original-Received: from g231107118.adsl.alicedsl.de ([92.231.107.118]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 14 Mar 2014 15:47:04 +0100 Original-Received: from tjolitz by g231107118.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 14 Mar 2014 15:47:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: g231107118.adsl.alicedsl.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Cancel-Lock: sha1:JJdLwolmxoHmf10vtrthCw/UN1I= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:96508 Archived-At: Stefan writes: >> Is it generally considered a (kind of) bug when a COMMAND (not a >> function) calls y-or-n-p unconditionally (or enforces user input in >> other ways)? > > Not sure about "generally", but it's a good principle to decompose > a functionality into a "batch-only" part and an interactive wrapper. So rather than adding additional function args to the command and using something like (when (called-interactively-p) ...) the canonical way would be to split the command into a function (probably with additional function args) and a command that calls this function (the interactive wrapper)? > So we probably wouldn't consider all such cases as bugs, but if > a particular case is problematic, you should definitely request the > change (which we may sometimes reject, of course, typically if it would > require too many/ugly modifications to the code). This would be more directed towards Org-mode I think ... What if a command/function is overly verbose wrt to messages when used in a program? Is it reasonable to ask for including an optional switch like this (defun xyz (args &optional quiet) (unless quiet (message ...))) to be able to suppress all the messages in the function call? -- cheers, Thorsten