From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Date: Mon, 16 Jun 2014 09:51:17 +0300 Organization: JURTA Message-ID: <87fvj5fq8q.fsf@mail.jurta.org> References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> <539801FA.2040400@gmx.at> <87vbs6r61k.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402901859 18599 80.91.229.3 (16 Jun 2014 06:57:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Jun 2014 06:57:39 +0000 (UTC) Cc: 17554@debbugs.gnu.org, Roland Winkler To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 16 08:57:31 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WwQrC-0003d1-OP for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jun 2014 08:57:30 +0200 Original-Received: from localhost ([::1]:41858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwQrC-0004KC-7q for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jun 2014 02:57:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwQqs-0003oo-Nm for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 02:57:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwQql-0004pt-4G for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 02:57:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwQql-0004pp-1d for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 02:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WwQqk-0008SW-RA for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 02:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jun 2014 06:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17554-submit@debbugs.gnu.org id=B17554.140290181432485 (code B ref 17554); Mon, 16 Jun 2014 06:57:02 +0000 Original-Received: (at 17554) by debbugs.gnu.org; 16 Jun 2014 06:56:54 +0000 Original-Received: from localhost ([127.0.0.1]:48673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwQqb-0008Rn-7j for submit@debbugs.gnu.org; Mon, 16 Jun 2014 02:56:53 -0400 Original-Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:34543 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwQqZ-0008Re-54 for 17554@debbugs.gnu.org; Mon, 16 Jun 2014 02:56:51 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 0C467349517F58; Sun, 15 Jun 2014 23:56:48 -0700 (PDT) In-Reply-To: <87vbs6r61k.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 12 Jun 2014 09:33:11 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90420 Archived-At: >> But the 24.3 code handles Roland's scenario by displaying *Completions* >> in a third window. At least it does so here. What do you get? > > 24.3 displays *Completions* in the window with the dired buffer > because the lru-window is the dired window in 24.3, but in 24.4 > the lru-window is the small window with *Marked Files*. > > Maybe it's possible to change window's timestamp after displaying > *Marked Files* to make the dired window lru, to display *Completions* > in it like in 24.3? The problem is that `with-selected-window' calls `select-window' with the non-nil arg `norecord' that doesn't update the window's use_time, so the displayed window considered least-recently used. I don't know how general this problem is, but at least for *Marked files* the following patch causes the Dired window to be least-recently used, thus avoiding using *Marked files* window to display *Completions*: === modified file 'lisp/dired.el' --- lisp/dired.el 2014-05-08 19:22:43 +0000 +++ lisp/dired.el 2014-06-16 06:45:18 +0000 @@ -3107,6 +3107,7 @@ (defun dired-mark-pop-up (buffer-or-name '((window-height . fit-window-to-buffer))) #'(lambda (window _value) (with-selected-window window + (select-window window) ;; use nil NORECORD to make window the most recently selected. (unwind-protect (apply function args) (when (window-live-p window)