From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 17554@debbugs.gnu.org, Roland Winkler <winkler@gnu.org>
Subject: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window
Date: Mon, 16 Jun 2014 09:51:17 +0300 [thread overview]
Message-ID: <87fvj5fq8q.fsf@mail.jurta.org> (raw)
In-Reply-To: <87vbs6r61k.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 12 Jun 2014 09:33:11 +0300")
>> But the 24.3 code handles Roland's scenario by displaying *Completions*
>> in a third window. At least it does so here. What do you get?
>
> 24.3 displays *Completions* in the window with the dired buffer
> because the lru-window is the dired window in 24.3, but in 24.4
> the lru-window is the small window with *Marked Files*.
>
> Maybe it's possible to change window's timestamp after displaying
> *Marked Files* to make the dired window lru, to display *Completions*
> in it like in 24.3?
The problem is that `with-selected-window' calls `select-window' with
the non-nil arg `norecord' that doesn't update the window's use_time,
so the displayed window considered least-recently used.
I don't know how general this problem is, but at least for *Marked files*
the following patch causes the Dired window to be least-recently used,
thus avoiding using *Marked files* window to display *Completions*:
=== modified file 'lisp/dired.el'
--- lisp/dired.el 2014-05-08 19:22:43 +0000
+++ lisp/dired.el 2014-06-16 06:45:18 +0000
@@ -3107,6 +3107,7 @@ (defun dired-mark-pop-up (buffer-or-name
'((window-height . fit-window-to-buffer)))
#'(lambda (window _value)
(with-selected-window window
+ (select-window window) ;; use nil NORECORD to make window the most recently selected.
(unwind-protect
(apply function args)
(when (window-live-p window)
next prev parent reply other threads:[~2014-06-16 6:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 19:59 bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Roland Winkler
2014-05-23 1:07 ` Stefan Monnier
2014-05-23 2:17 ` Roland Winkler
2014-05-23 6:06 ` Eli Zaretskii
2014-05-23 7:24 ` martin rudalics
2014-05-23 21:32 ` Juri Linkov
2014-05-27 21:54 ` Juri Linkov
2014-05-27 22:45 ` Roland Winkler
2014-06-05 23:48 ` Juri Linkov
2014-06-06 1:07 ` Stefan Monnier
2014-06-06 4:17 ` Roland Winkler
2014-06-06 23:05 ` Juri Linkov
2014-06-09 16:15 ` Roland Winkler
2014-06-10 0:12 ` Juri Linkov
2014-06-10 6:07 ` martin rudalics
2014-06-10 22:57 ` Juri Linkov
2014-06-11 7:15 ` martin rudalics
2014-06-12 6:33 ` Juri Linkov
2014-06-16 6:51 ` Juri Linkov [this message]
2014-06-16 19:49 ` Roland Winkler
2014-06-16 21:47 ` Stefan Monnier
2014-06-17 6:44 ` Juri Linkov
2014-06-18 7:57 ` Juri Linkov
2014-06-06 23:04 ` Juri Linkov
2014-06-18 8:07 ` Juri Linkov
2014-05-23 5:48 ` Eli Zaretskii
2014-05-23 7:25 ` martin rudalics
2014-05-23 7:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvj5fq8q.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=17554@debbugs.gnu.org \
--cc=rudalics@gmx.at \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.