From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19274: tar-mode.el: allow for adding new archive members Date: Fri, 05 Dec 2014 20:20:24 +0000 Message-ID: <87fvctn913.fsf@violet.siamics.net> References: <877fy7nmgt.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1417810884 2558 80.91.229.3 (5 Dec 2014 20:21:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Dec 2014 20:21:24 +0000 (UTC) To: 19274@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 05 21:21:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwzNN-0001Lc-ER for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Dec 2014 21:21:17 +0100 Original-Received: from localhost ([::1]:52353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwzNM-0002Vi-Us for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Dec 2014 15:21:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwzNG-0002Vc-Qk for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2014 15:21:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwzNA-0002yg-As for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2014 15:21:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwzN8-0002xi-5x for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2014 15:21:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XwzN7-0006qb-NR for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2014 15:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Dec 2014 20:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19274 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19274-submit@debbugs.gnu.org id=B19274.141781084126284 (code B ref 19274); Fri, 05 Dec 2014 20:21:01 +0000 Original-Received: (at 19274) by debbugs.gnu.org; 5 Dec 2014 20:20:41 +0000 Original-Received: from localhost ([127.0.0.1]:54991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwzMm-0006ps-CB for submit@debbugs.gnu.org; Fri, 05 Dec 2014 15:20:40 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:43606) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwzMh-0006pf-K5 for 19274@debbugs.gnu.org; Fri, 05 Dec 2014 15:20:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=D33T58n2qeWLAZxYJfUs9aw3B1+6WUsdbpV6VnnqoKA=; b=q44ZNN2Ab6zIFdrNTx7mC6x77iSJHxjnHttLp8Fn3tDhyQrXGSaw7rz+oD7SDsUVTne8tTw9OkrugpBWsn9bEmyLewKEzjIvmVnsbetWyBOxouqxLZKTZBX3UWIkFbi52ywhEUUsKdNmlAmV8fH6Ddsf39n+J46+0piFzn0LhJY=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XwzMe-0002zW-MC for 19274@debbugs.gnu.org; Fri, 05 Dec 2014 20:20:33 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XwzMX-0000RL-Go for 19274@debbugs.gnu.org; Sat, 06 Dec 2014 03:20:25 +0700 Mail-Followup-To: 19274@debbugs.gnu.org In-Reply-To: (Stefan Monnier's message of "Thu, 04 Dec 2014 21:10:18 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96903 Archived-At: >>>>> Stefan Monnier writes: [=E2=80=A6] >> + ;; omit tar-header-checksum (tar-chk-offset) for now > Please capitalize and punctuate your comments. Even the one-line ones? Given that I have some time to improve this patch, could someone please suggest a good place to add a menu entry for tar-new-entry in tar-mode-map? (I never use Emacs=E2=80=99 menus myself, so I=E2=80=99m rather clueless on this.) BTW, I wonder if it makes sense to split the make-tar-header form (with all the nil=E2=80=99s there) off tar-new-entry into a new (tar-new-regular-file-header filename &optional size time) function? I guess that=E2=80=99d ease the creation of Tar archives from Emacs Lisp code; (and I already imagine some uses to that.) I=E2=80=99ll also write a proper docstring for tar-header-serialize, so to make it clear this function is part of the module=E2=80=99s external interface. PS. you know you may be a mathematician if your sentences start with a lower-case letter and end with a semicolon; --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A.