From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: Is INLINE_HEADER_BEGIN still useful? Date: Wed, 29 Apr 2015 17:33:03 +0200 Message-ID: <87fv7jkl00.fsf@gmail.com> References: <87h9rzb2nc.fsf@gmail.com> <5540E3E2.4030701@cs.ucla.edu> <87r3r3nhvm.fsf@gmail.com> <5540F3BC.4070905@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1430321962 17051 80.91.229.3 (29 Apr 2015 15:39:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 Apr 2015 15:39:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 29 17:39:17 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YnU4s-0001Sf-FH for ged-emacs-devel@m.gmane.org; Wed, 29 Apr 2015 17:39:10 +0200 Original-Received: from localhost ([::1]:39705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnU4r-00054x-41 for ged-emacs-devel@m.gmane.org; Wed, 29 Apr 2015 11:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnU4n-00054p-IT for emacs-devel@gnu.org; Wed, 29 Apr 2015 11:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnU4h-0002Rx-2G for emacs-devel@gnu.org; Wed, 29 Apr 2015 11:39:05 -0400 Original-Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:37026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnU4g-0002RH-RJ for emacs-devel@gnu.org; Wed, 29 Apr 2015 11:38:58 -0400 Original-Received: by widdi4 with SMTP id di4so70677937wid.0 for ; Wed, 29 Apr 2015 08:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=PxXSqzgIp5rNGS1umExe4YDE+cr9XwcjQtj7jUw3EYw=; b=gN18n0JW+59UmcXgTdKVXGepwwhVfjQbtws7FITjL/84gIac0wVv5O7Ni7JsZ7FQEm Bz3etGNYBTILy6H4MqRpIa7t8Q9RXnBReSZY/S48FXW7Nv5RoE2M74r6TX8PVqp/Lc0w 3u2OWZQqamrGlAhj7BzJRIUoOYUVcGfdvqai++GJHbUG6OE/yv1snN6u+pSS54pql1w3 fcGRsLoaeRRqERpBxAUQpyP/HHZQqBiEJe8Z8h56IpByqFYWboMXCkI8YvCzuQaRe5h3 xasCliaQlgTJicVRZAV8P+yG3ljWl4wPzi57ZujL+PxjItVHqVA9YmNPSrII55G13Nhv HR8Q== X-Received: by 10.194.234.38 with SMTP id ub6mr7635743wjc.9.1430321936139; Wed, 29 Apr 2015 08:38:56 -0700 (PDT) Original-Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id e10sm21716086wij.11.2015.04.29.08.38.55 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 29 Apr 2015 08:38:55 -0700 (PDT) In-Reply-To: <5540F3BC.4070905@cs.ucla.edu> (Paul Eggert's message of "Wed, 29 Apr 2015 08:07:40 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186019 Archived-At: Paul Eggert writes: > Oleh Krehel wrote: >> I got no warnings when I tested my buffer.h patch. > > Try './configure --enable-gcc-warnings'. Certainly the warnings do > appear on some modern GCC implementations -- otherwise we wouldn't > have gone to all that work to suppress them so recently. OK, but that just makes each warning into an error. My build terminates for unused variable "spool_name", which is unused because I don't have the right configuration. >> Maybe someone on the list >> could respond if they use a compiler that doesn't support the C99 >> "inline" declaration? > > It's not as simple as that. Although most compilers have grokked the > 'inline' keyword for some time, this does not imply full support for > C99 'inline' everywhere. For example, OS X 10.8's standard headers do > not work when used by extern inline functions, so Emacs can't simply > assume C99 inline will work on this relatively recent platform > (released July 2012 and still in wide use). Not all inline are extern inline, buffer.h doesn't need to be extern inline, if I understand correctly. But anyway, if you say it's needed, it's needed. One more question, is there a list of platforms on which Emacs is known to build fine, by version? Maybe 25.1 doesn't build on OS X 10.8 for reasons other than C99 compatibility. Oleh