From: Juri Linkov <juri@linkov.net>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: 20925@debbugs.gnu.org
Subject: bug#20925: 25.0.50; isearch-exit calls isearch-done twice
Date: Tue, 30 Jun 2015 01:07:08 +0300 [thread overview]
Message-ID: <87fv5a184z.fsf@mail.linkov.net> (raw)
In-Reply-To: <b4mzj3i6f0p.fsf@jpl.org> (Katsumi Yamaoka's message of "Mon, 29 Jun 2015 18:27:18 +0900")
> `isearch-exit' calls `isearch-done' by way of `isearch-edit-string'
> and `with-isearch-suspended', and then calls it again.
> I don't know why it does so but this change gets rid of the error:
>
> --- isearch.el~ 2015-06-28 22:04:38.000000000 +0000
> +++ isearch.el 2015-06-29 09:26:19.216444200 +0000
> @@ -1184,8 +1184,8 @@
> (if (and search-nonincremental-instead
> (= 0 (length isearch-string)))
> (let ((isearch-nonincremental t))
> - (isearch-edit-string)))
> - (isearch-done)
> + (isearch-edit-string))
> + (isearch-done))
> (isearch-clean-overlays))
Thanks, I believe this is the right fix to avoid calling
‘isearch-done’ twice. Could you please add a short 1-line comment
explaining that ‘isearch-edit-string’ already calls ‘isearch-done’.
next prev parent reply other threads:[~2015-06-29 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 9:27 bug#20925: 25.0.50; isearch-exit calls isearch-done twice Katsumi Yamaoka
2015-06-29 22:07 ` Juri Linkov [this message]
2015-06-29 23:13 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv5a184z.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=20925@debbugs.gnu.org \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.