From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 21435@debbugs.gnu.org, Tassilo Horn <tsdh@gnu.org>
Subject: bug#21435: 25.0.50; file-notify has problems after renames
Date: Tue, 08 Sep 2015 20:04:20 +0200 [thread overview]
Message-ID: <87fv2ovlcr.fsf@gmx.de> (raw)
In-Reply-To: <83k2s07vaf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Sep 2015 19:03:36 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> IOW, technically, the file/directory you watched disappeared from the
> filesystem, so what is reported afterwards is IMO entirely resonable
> at this low level.
Well, inotify sends then the low-level event `delete-self', which is
different from the usual `delete'. filenotify.el translates both to the
upper-level event `deleted'. In case of `delete-self', filenotify.el
could do something more, like removing the watch. Do we want this?
> One application we have on top of filenotify.el is auto-revert.el.
> Now, if you see some user-level problems there when files are
> renamed/deleted, please report them.
>
>> Another thing is that renames always seem to be reported twice (although
>> the example in the manual lists only one event but that example has
>> probably gathered with the gfilenotify backend).
>
> This doesn't happen with w32notify. filenotify.el includes some code
> to produce a single notification out of the 2 reported by back-ends in
> this case; perhaps something doesn't work there with inotify. Can you
> step through the code and see why?
Two days ago (commit dbdc459a48091f5953faf14bcaaa7e6d37fbf024), I've
changed filenotify.el to fire 2 events `renamed' in case the directories
of the source and target are different. This was triggered by a user
report, that he wants to have auto-revert-mode for two different
directories under dired control. So the event is sent for the two
different handlers activated by the respective *-add-watch calls.
I've tested for inotify, it works (confirmed by that user). The use case
of that user was, that a file has been moved outside Emacs from one
directory to the other. An he wanted to see it in both dired buffers,
immediately.
I couldn't test this for w32notify, but it should behave like this since
Sunday. I haven't changed it in gfilenotify yet, it's on my todo
list. And the manual must be adapted, as Tassilo has said.
Best regards, Michael.
PS: Tassilo, you write great test cases. Do you want to contribute to
test/automated/file-notify-tests.el?
PPS: Forgive me slow progress; I'm still suffering from health problems.
next prev parent reply other threads:[~2015-09-08 18:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 8:47 bug#21435: 25.0.50; file-notify has problems after renames Tassilo Horn
2015-09-08 16:03 ` Eli Zaretskii
2015-09-08 18:04 ` Michael Albinus [this message]
2015-09-08 18:21 ` Eli Zaretskii
2015-09-08 19:28 ` Tassilo Horn
2015-09-09 18:15 ` Michael Albinus
2015-09-09 19:01 ` Tassilo Horn
2015-09-09 20:23 ` Tassilo Horn
2015-09-10 11:23 ` Michael Albinus
2015-09-10 15:31 ` Tassilo Horn
2015-09-10 17:50 ` Michael Albinus
2015-09-10 19:22 ` Tassilo Horn
2015-09-11 9:53 ` Michael Albinus
2015-09-11 12:17 ` Tassilo Horn
2015-09-11 12:32 ` Eli Zaretskii
2015-09-12 8:44 ` Michael Albinus
2015-09-11 9:45 ` Michael Albinus
2015-09-11 12:11 ` Tassilo Horn
2015-09-09 18:41 ` Michael Albinus
2015-09-09 19:21 ` Eli Zaretskii
2015-09-10 11:09 ` Michael Albinus
2015-09-10 15:45 ` Eli Zaretskii
2015-09-10 17:37 ` Michael Albinus
2015-09-10 18:03 ` Eli Zaretskii
2015-09-10 18:20 ` Michael Albinus
2015-09-10 18:55 ` Eli Zaretskii
2015-09-11 12:51 ` Michael Albinus
2015-09-08 19:05 ` Tassilo Horn
2015-09-08 19:19 ` Eli Zaretskii
2015-09-08 19:47 ` Tassilo Horn
2015-09-09 2:39 ` Eli Zaretskii
2015-09-09 6:13 ` Tassilo Horn
2015-09-20 17:26 ` Michael Albinus
2015-09-20 19:36 ` Eli Zaretskii
2015-09-21 6:25 ` Michael Albinus
2015-09-21 7:54 ` Eli Zaretskii
2015-09-21 10:13 ` Michael Albinus
2015-09-21 10:14 ` Eli Zaretskii
2015-09-21 13:11 ` Michael Albinus
2015-09-21 13:31 ` Eli Zaretskii
2015-09-21 13:38 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv2ovlcr.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=21435@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.