From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode? Date: Wed, 06 Jan 2016 10:14:41 +0100 Message-ID: <87fuybqdby.fsf@gmail.com> References: <83d1tg57p6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1452071702 8284 80.91.229.3 (6 Jan 2016 09:15:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2016 09:15:02 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 06 10:14:59 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aGkBF-0004gT-LY for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 10:14:57 +0100 Original-Received: from localhost ([::1]:53529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGkBB-00035t-Hj for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 04:14:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGkB8-00035n-9q for emacs-devel@gnu.org; Wed, 06 Jan 2016 04:14:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGkB4-0005oR-6i for emacs-devel@gnu.org; Wed, 06 Jan 2016 04:14:50 -0500 Original-Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:37381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGkB3-0005oN-W8; Wed, 06 Jan 2016 04:14:46 -0500 Original-Received: by mail-wm0-x232.google.com with SMTP id f206so66154668wmf.0; Wed, 06 Jan 2016 01:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=w8imfpxTS0MNG1umP95aSbvNCa9OARCx5c1Kz1n8kTk=; b=vkzjovdpaejPIedunLKPIeoXJupaLmiu+r6XxHQLSHJ2pU6BkXirGgMxkmaWWU9bOC fOJ2YKlvEdJ7MeI9CoAcs5+XdKzHwxKCi9Ok5zZl0uGjTVE8UY9dvALtiaz/I7ELbwsa yVHugnJsvxlLhJwwKysX4wYCasD2Q4l3/8Iq8w+IVWULoLmZsGI9iIiilK9wmnloz7QA s2tN3lGmK1q0h00WiXOndH0n3BXSrTGtADRPFZuPtvEZkL+QowVCmtcxgqPqsytE248I KTa8X+qX6Vd4dmKOwWUZd5b6+4I3x1XELpvx0TTzgEnBiYsim83k5XkES4pK0zSWQbLv hQyQ== X-Received: by 10.194.93.102 with SMTP id ct6mr93103574wjb.157.1452071685240; Wed, 06 Jan 2016 01:14:45 -0800 (PST) Original-Received: from firefly ([91.219.111.102]) by smtp.gmail.com with ESMTPSA id wf8sm62799506wjb.45.2016.01.06.01.14.43 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 06 Jan 2016 01:14:44 -0800 (PST) In-Reply-To: (Leo Liu's message of "Wed, 06 Jan 2016 07:11:21 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197691 Archived-At: Hi Leo, Leo Liu writes: > The introduction of (indent 1) to define-minor-mode. I have quite a few > define-minor-mode instances starting like this: > > (define-minor-mode some_fancy_mode nil > ...) > > The indentation is changed between emacs < 25 and 25. I added an (indent 1) statement around a year ago. The reason is that it didn't have one before, and that (indent 1) is obviously the correct indentation level. Every `define-minor-mode' statement in the core (and org-mode, and most of ELPA) already obeys the (intent 1) convention. It seems that you were defining minor modes in your config (and ELPA) with nil instead of the docstring. I suggest to either add a docstring or put a newline after the minor mode name. Oleh