From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Showing the relevant part of a diff Date: Fri, 19 Feb 2016 16:49:35 +1100 Message-ID: <87fuwp8d1s.fsf@gnus.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455861023 31507 80.91.229.3 (19 Feb 2016 05:50:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Feb 2016 05:50:23 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: "Herring\, Davis" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 19 06:50:14 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aWdxF-0001Jd-Nl for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2016 06:50:13 +0100 Original-Received: from localhost ([::1]:48775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWdxF-00083J-0t for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2016 00:50:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWdxA-00080Z-Op for emacs-devel@gnu.org; Fri, 19 Feb 2016 00:50:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWdx7-0005xI-LI for emacs-devel@gnu.org; Fri, 19 Feb 2016 00:50:08 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:49078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWdx7-0005wM-EZ for emacs-devel@gnu.org; Fri, 19 Feb 2016 00:50:05 -0500 Original-Received: from 203-174-152-162.cust.static-ipl.aapt.com.au ([203.174.152.162] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aWdwi-0003vM-5h; Fri, 19 Feb 2016 06:49:40 +0100 In-Reply-To: (Davis Herring's message of "Fri, 19 Feb 2016 05:43:23 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aWdwi-0003vM-5h MailScanner-NULL-Check: 1456465781.15428@tfJ6s9RdV3Hz3wF901COaw X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200178 Archived-At: "Herring, Davis" writes: > When looking at changes made to a file, the ones most likely to be > interesting are those affecting the portion of the file in view. The > second attached patch causes `vc-diff' to place point at the place in > the diff that corresponds to point in the file being compared (only if > the current source is the endpoint of the diff, of course). This sounds very useful, I think. > To resolve: > 1. Would this need a NEWS entry? Yes. And documentation in the manual. > 2. Does it need to be customizable? (M-< is all it takes to "recover > the old behavior"...) I don't think it has to be customisable. > 3. Is it worth supporting the (very rare) "normal" diff format? That would be nice, but it's very rare to see those in the wild these days, so if it's a lot of work, it may not be worth it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no