From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Tue, 08 Mar 2016 14:39:12 +0800 Message-ID: <87fuw179tb.fsf@ericabrahamsen.net> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <64a52598-ad53-498c-993c-67d7827dbdfc@default> <838u1uuuau.fsf@gnu.org> <878u1um2xl.fsf@thinkpad.rath.org> <87io0xedoh.fsf@vostro.rath.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457419211 26220 80.91.229.3 (8 Mar 2016 06:40:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 06:40:11 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 07:39:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adBJ8-0005S2-Au for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 07:39:50 +0100 Original-Received: from localhost ([::1]:60652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adBJ7-0007UD-LX for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 01:39:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adBJ3-0007Tv-4c for emacs-devel@gnu.org; Tue, 08 Mar 2016 01:39:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adBIz-0001jy-PC for emacs-devel@gnu.org; Tue, 08 Mar 2016 01:39:45 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:36979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adBIz-0001jq-IL for emacs-devel@gnu.org; Tue, 08 Mar 2016 01:39:41 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1adBIt-0005G1-5D for emacs-devel@gnu.org; Tue, 08 Mar 2016 07:39:35 +0100 Original-Received: from 221.220.62.139 ([221.220.62.139]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Mar 2016 07:39:35 +0100 Original-Received: from eric by 221.220.62.139 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Mar 2016 07:39:35 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 39 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 221.220.62.139 User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:p2n45/Th9PkWsW/QHP7ay8ogeqo= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201132 Archived-At: Nikolaus Rath writes: > On Mar 07 2016, Stefan Monnier wrote: >>> When I submitted my first Emacs patch, I was astonished when I was asked >>> to re-submit with my commit message essentially duplicated in the >>> ChangeLog. >> >> I can't remember ever asking this kind of duplication. We used to >> duplicate the ChangeLog-info in the ChangeLog file and in the commit >> message (tho we stopped doing it a year ago), but we never asked for it >> to be duplicated in the email messages that submits a patch. >> >> So I have the impression that I'm misunderstanding you. Could you >> describe more precisely the kind of duplication you're talking about? > > No, you understood me correctly. However, I've just looked this up again > and it turns out I was actually submitting a patch to Gnus, not > Emacs. It was eventually committed by Eric Abrahamsen to the Gnus git > repo, who first asked me to re-submit my patch with a commit message > that was formatted like a Changelog entry, and to duplicate the message > in the ChangeLog itself. It seemed to me that he considered that a > questionable practice himself, but said it was obligatory because Gnus > closely followed the Emacs standards here. > > > Unfortunately that discussion never made it into the bug > (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20956), so I'm > paraphrasing from memory. But I'm pretty sure I'm remembering correctly, > because I was so surprised by this. Not duplicating it in the email, just commit message + ChangeLog duplication. This may be getting conflated with me asking for the commit to be emailed as a git-format-patch attachment, which was just because I was lazy (and it also preserves the author/committer distinction). But yes, Gnus was doing the ChangeLog dance right up until the repo merged with Emacs -- I pushed a couple of changes there just before that, neglecting to include the ChangeLog, and someone went and cleaned up after me. Embarrassing.